fix: fix tests and commit message to follow guidelines

Author: goetzrobin

.github/workflows/nightly-release.yml

@@ -123,6 +123,6 @@ jobs:
         with:
           author_name: Leonidas
           author_email: [email protected]
-          message: 'nightly release ${{steps.datetime.outputs.release_date}} ⚡'
+          message: 'chore: nightly release ${{steps.datetime.outputs.release_date}} ⚡'
       - name: Release
         run: pnpm run release

libs/tools/src/executors/release/build-update-publish/executor.spec.ts

@@ -1,7 +1,6 @@
 import * as childProcess from 'node:child_process';
 import * as projectHelper from '../helpers/projects.helpers';
 import * as npmPublish from '../npm-publish/executor';
-import * as updateVersion from '../update-version/executor';
 import executor from './executor';
 
 // Mock the entire child_process module
@@ -15,7 +14,7 @@ describe('BuildUpdatePublish Executor', () => {
 		// eslint-disable-next-line @typescript-eslint/no-explicit-any
 		const mockContext = { bar: 'bar' } as any;
 
-		// Mock the project helper, updateVersion, npmPublish, and execSync
+		// Mock the project helper, npmPublish, and execSync
 		jest.spyOn(projectHelper, 'getProjectName').mockReturnValue(libName);
 
 		// Mock npmPublish to return { success: true }
@@ -28,7 +27,6 @@ describe('BuildUpdatePublish Executor', () => {
 		const output = await executor({}, mockContext);
 
 		// Verify that all functions are called as expected
-		expect(updateVersion.default).toHaveBeenCalledWith({}, mockContext);
 		expect(npmPublish.default).toHaveBeenCalledWith({}, mockContext);
 		expect(execSyncMock).toHaveBeenCalledWith(expectedCommand);
 		expect(output.success).toBe(true);

libs/tools/src/generators/replace-cli-version/generator.spec.ts

@@ -1,19 +1,17 @@
 import { type Tree, readProjectConfiguration } from '@nx/devkit';
 import { createTreeWithEmptyWorkspace } from '@nx/devkit/testing';
 
-import { replaceCliVersionGenerator } from './generator';
-import type { ReplaceCliVersionGeneratorSchema } from './schema';
+import replaceCliVersionGenerator from './generator';
 
 describe('replace-cli-version generator', () => {
 	let tree: Tree;
-	const options: ReplaceCliVersionGeneratorSchema = {};
 
 	beforeEach(() => {
 		tree = createTreeWithEmptyWorkspace();
 	});
 
 	it.skip('should run successfully', async () => {
-		await replaceCliVersionGenerator(tree, options);
+		await replaceCliVersionGenerator(tree);
 		const config = readProjectConfiguration(tree, 'test');
 		expect(config).toBeDefined();
 	});

libs/tools/src/generators/replace-ui-version/generator.ts

@@ -46,7 +46,7 @@ const replaceUiVersionInCliVersionsFile = (tree: Tree, oldVersion: string, newVe
 	tree.write(filePath, contents);
 };
 
-export default async function replaceUiVersionGenerator(tree: Tree, options: { newVersion: string }): Promise<void> {
+export default async function replaceUiVersionGenerator(tree: Tree, options?: { newVersion: string }): Promise<void> {
 	const relativePackageJsonFilePaths = [
 		...(await recursivelyFindRelativePackageJsonFilePaths('libs/ui')),
 		// this is going to be our main package going forward which contains all primitives as secondary entry points
@@ -56,7 +56,7 @@ export default async function replaceUiVersionGenerator(tree: Tree, options: { n
 	// this goes into the accordion's package.json, which should always be defined
 	// if there is no version there we should definitely not move forward
 	const oldVersion = readJsonFile(relativePackageJsonFilePaths[0]).version;
-	const newVersion = options.newVersion ?? process.env.VERSION;
+	const newVersion = options?.newVersion ?? process.env.VERSION;
 
 	if (!oldVersion) {
 		console.error(