Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in hlm-dialog with icons #446

Open
1 of 2 tasks
Impre-visible opened this issue Nov 7, 2024 · 0 comments
Open
1 of 2 tasks

Bug in hlm-dialog with icons #446

Impre-visible opened this issue Nov 7, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Impre-visible
Copy link

Impre-visible commented Nov 7, 2024

Please provide the environment you discovered this bug in.

import { Component } from '@angular/core';
import { lucideX, lucidePlus } from '@ng-icons/lucide';
import { NgIcon, provideIcons } from '@ng-icons/core';
import { BrnDialogComponent, BrnDialogImports } from '@spartan-ng/ui-dialog-brain';
import { HlmDialogImports } from '@spartan-ng/ui-dialog-helm';

@Component({
  selector: 'app-root',
  standalone: true,
  imports: [NgIcon],
  viewProviders: [provideIcons({ lucideX, lucidePlus })],
  template: `
  <hlm-dialog-content *brnDialogContent="let ctx" class="max-w-4xl">
	  <hlm-dialog-header>
	      <h3 hlmDialogTitle hlm>Icon in dialog test</h3>
	  </hlm-dialog-header>
	  <div hlmDialogOverlay class="max-w-none">
	      <div hlmDialogContent class="!max-w-none">
	          <ng-icon name="lucideX" />
	      	  <ng-icon name="lucidePlus" />
    	  </div>
      </div>
  </hlm-dialog-content>
  `,
})
export class App {}

Which area/package is the issue in?

dialog

Description

When you want to register/provide an icon, and display it in a hlm-dialog, it don't show up if you didn't provided it in the root AppComponent.

Please provide the exception or error you saw

"No icon named ... was found. You may need to import it using the withIcons function."

Other information

Here's the discord discussion when we found the issue: https://discord.com/channels/1145362148621557921/1304180397067731085

I would be willing to submit a PR to fix this issue

  • Yes
  • No
@Impre-visible Impre-visible added the bug Something isn't working label Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant