feat(date-picker): autoCloseOnSelect option and open/close programmatically #626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goetzrobin
reviewed
Mar 19, 2025
| @@ -22,6 +27,7 @@ function getDefaultConfig<T>(): HlmDatePickerConfig<T> { | |||
| return { | |||
| formatDate: (date) => (date instanceof Date ? date.toDateString() : `${date}`), | |||
| transformDate: (date) => date, | |||
| autoCloseOnSelect: false, | |||
There was a problem hiding this comment.
Do you think this should default to true?
There was a problem hiding this comment.
hmmm does not seem to be the default behavior in shadcn.
I would even suggest to remove it from the preview, but it is not a stopper. ;)
There was a problem hiding this comment.
I set it to false to have the same behavior as in shadcn. I can remove it from the first preview and added to one of the other
elite-benni
approved these changes
Mar 19, 2025
| @@ -22,6 +27,7 @@ function getDefaultConfig<T>(): HlmDatePickerConfig<T> { | |||
| return { | |||
| formatDate: (date) => (date instanceof Date ? date.toDateString() : `${date}`), | |||
| transformDate: (date) => date, | |||
| autoCloseOnSelect: false, | |||
There was a problem hiding this comment.
hmmm does not seem to be the default behavior in shadcn.
I would even suggest to remove it from the preview, but it is not a stopper. ;)
|
I updated the example and moved |
|
Thanks! ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
guidelines: https://github.com/goetzrobin/spartan/blob/main/CONTRIBUTING.md#-commit-message-guidelines
PR Type
What kind of change does this PR introduce?
Which package are you modifying?
What is the current behavior?
Closes #597
What is the new behavior?
Does this PR introduce a breaking change?
Other information