wip

Author: freekmurze

CHANGELOG.md

@@ -4,6 +4,10 @@ All notable changes to `dns` will be documented in this file
 
 ## 2.3.1 - 2021-11-02
 
+- fix macroable behaviour
+
+## 2.3.1 - 2021-11-02
+
 - allow v1 of spatie/macroable
 
 ## 2.3.0 - 2021-11-02

src/Records/Record.php

@@ -17,7 +17,9 @@
  */
 abstract class Record implements Stringable
 {
-    use Macroable;
+    use Macroable {
+        __call as protected macroCall;
+    }
 
     protected string $host;
     protected int $ttl;
@@ -72,7 +74,7 @@ public function __call(string $name, array $arguments)
             return $this->$name;
         }
 
-        throw new BadMethodCallException();
+        return $this->macroCall($name, $arguments);
     }
 
     protected static function lineToArray(string $line, ?int $limit = null): array

tests/Records/RecordTest.php

@@ -0,0 +1,20 @@
+<?php
+
+namespace Spatie\Dns\Test\Records;
+
+use PHPUnit\Framework\TestCase;
+use Spatie\Dns\Records\A;
+use Spatie\Dns\Records\Record;
+
+class RecordTest extends TestCase
+{
+    /** @test */
+    public function a_record_is_macroable()
+    {
+        Record::macro('ping', fn() => 'pong');
+
+        $record = A::parse('spatie.be.              900     IN      A       138.197.187.74');
+
+        $this->assertEquals('pong', $record->ping());
+    }
+}