moveToStart updates wrong rows

[quelo83]

Hi,
the method "moveToStart" doesn't seem to work well. It increments all rows except the current model and this is not correct.
The current code is:

$this->$orderColumnName = $firstModel->$orderColumnName;
$this->save();

$this->buildSortQuery()->where($this->getKeyName(), '!=', $this->getKey())->increment($orderColumnName);

If I'm not wrong, the query should have another where clause to scope and increment only the previous rows, something like this:

$previousOrder = $this->$orderColumnName;

$this->$orderColumnName = $firstModel->$orderColumnName;
$this->save();

$this->buildSortQuery()
    ->where($this->getKeyName(), '!=', $this->getKey())
    ->where($this->getKeyName(), '<', $previousOrder)
    ->increment($orderColumnName);

Please, let me know if I'm missing something.

Thanks in advance!

[mokhosh]

This makes sense, but it shouldn't break the sort, right? The only issue is you will have a gap like 1,2,3,5,6.