tap() function returns error

[yangshengjie4u]

Here is my code in Controller,

use Spatie\Activitylog\Contracts\Activity;
......
class DataController extends Controller
{
 public function erase($id){
        ......
        activity('Data record')
            ->causedBy(Auth::user()->id)
            ->log('batch delete')
            ->tap(function(Activity $activity) use ($group, $gid)  {
                $activity->show_changes='Records under '.Data::find($id)->name.' are deleted';
            });
     ......
    }
}

However, it returns error when I call the erase(),

Argument 1 passed to App\Http\Controllers\DataRecordController::App\Http\Controllers\{closure}() must implement interface Spatie\Activitylog\Contracts\Activity, 
instance of Illuminate\Database\Eloquent\Builder given, 
called in .../vendor/laravel/framework/src/Illuminate/Support/Traits/Conditionable.php on line 19

Any hints？Thanks!

[Gummibeer]

Hey,
yes your tap() call is too late in the fluent chain. The log() method doesn't return an instance of the ActivityLogger anymore but an instance of the Activity model. So you aren't calling our ActivityLogger::tap() method but the Laravel Core/Eloquent Model one.

laravel-activitylog/src/ActivityLogger.php

Lines 156 to 174 in 0da6f05

	public function log(string $description): ?ActivityContract
	{
	if ($this->logStatus->disabled()) {
	return null;
	}
	$activity = $this->activity;
	$activity->description = $this->replacePlaceholders(
	$activity->description ?? $description,
	$activity
	);
	$activity->save();
	$this->activity = null;
	return $activity;
	}

So you should change it to

activity('Data record')
    ->causedBy(Auth::user()->id)
    ->tap(function(Activity $activity) use ($group, $gid)  {
        $activity->show_changes='Records under '.Data::find($id)->name.' are deleted';
    })
    ->log('batch delete');

This will do what you expect it to do.

[yangshengjie4u]

Work like a charm, thanks!