Merge pull request #923 from spatie/fix/903

Fix an issue where anonymous classes in castables were serialized (#903)

Author: rubenvanassche

src/Attributes/WithCastable.php

@@ -5,6 +5,7 @@
 use Attribute;
 use Spatie\LaravelData\Casts\Cast;
 use Spatie\LaravelData\Casts\Castable;
+use Spatie\LaravelData\Casts\CastableCast;
 use Spatie\LaravelData\Exceptions\CannotCreateCastAttribute;
 
 #[Attribute(Attribute::TARGET_CLASS | Attribute::TARGET_PROPERTY)]
@@ -26,6 +27,9 @@ public function __construct(
 
     public function get(): Cast
     {
-        return $this->castableClass::dataCastUsing(...$this->arguments);
+        return new CastableCast(
+            $this->castableClass,
+            $this->arguments
+        );
     }
 }

src/Casts/CastableCast.php

@@ -0,0 +1,43 @@
+<?php
+
+namespace Spatie\LaravelData\Casts;
+
+use Spatie\LaravelData\Support\Creation\CreationContext;
+use Spatie\LaravelData\Support\DataProperty;
+
+class CastableCast implements Cast
+{
+    protected Cast $cast;
+
+    /**
+     * @param class-string<\Spatie\LaravelData\Casts\Castable> $castableClass
+     */
+    public function __construct(
+        public string $castableClass,
+        public array $arguments
+    ) {
+    }
+
+    public function cast(DataProperty $property, mixed $value, array $properties, CreationContext $context): mixed
+    {
+        if (! isset($this->cast)) {
+            $this->cast = $this->castableClass::dataCastUsing(...$this->arguments);
+        }
+
+        return $this->cast->cast($property, $value, $properties, $context);
+    }
+
+    public function __serialize(): array
+    {
+        return [
+            'castableClass' => $this->castableClass,
+            'arguments' => $this->arguments,
+        ];
+    }
+
+    public function __unserialize(array $data): void
+    {
+        $this->castableClass = $data['castableClass'];
+        $this->arguments = $data['arguments'];
+    }
+}

src/Support/Factories/DataClassFactory.php

@@ -33,7 +33,6 @@ public function __construct(
     ) {
     }
 
-
     public function build(ReflectionClass $reflectionClass): DataClass
     {
         /** @var class-string<Data> $name */

tests/Support/Caching/CachedDataConfigTest.php

@@ -3,11 +3,14 @@
 use Illuminate\Support\Facades\App;
 use Illuminate\Support\Facades\Cache;
 use Mockery\MockInterface;
+use Spatie\LaravelData\Attributes\WithCastable;
+use Spatie\LaravelData\Data;
 use Spatie\LaravelData\Support\Caching\CachedDataConfig;
 use Spatie\LaravelData\Support\Caching\DataStructureCache;
 use Spatie\LaravelData\Support\DataClass;
 use Spatie\LaravelData\Support\DataConfig;
 use Spatie\LaravelData\Tests\Factories\FakeDataStructureFactory;
+use Spatie\LaravelData\Tests\Fakes\Castables\SimpleCastable;
 use Spatie\LaravelData\Tests\Fakes\SimpleData;
 
 function ensureDataWillBeCached()
@@ -104,3 +107,32 @@ function (MockInterface $spy) use ($dataClass) {
 
     cache()->get('something-just-to-test-the-mock');
 });
+
+it('is possible to cache data classes with castables using anonymous classes', function () {
+    ensureDataWillBeCached();
+
+    $objectDefinition = new class () extends Data {
+        #[WithCastable(SimpleCastable::class, normalize: true)]
+        public SimpleCastable $string;
+    };
+
+    $dataClass = app(DataConfig::class)->getDataClass($objectDefinition::class);
+
+    expect(isset(invade($dataClass->properties['string']->cast)->cast))->toBeFalse();
+
+    $objectDefinition::from(['string' => 'Hello world']);
+
+    $dataClass = app(DataConfig::class)->getDataClass($objectDefinition::class);
+
+    $reflection = new ReflectionClass(invade($dataClass->properties['string']->cast)->cast);
+
+    expect($reflection->isAnonymous())->toBeTrue();
+
+    $dataClass->prepareForCache();
+
+    app(DataStructureCache::class)->storeDataClass($dataClass);
+
+    $newDataClass = app(DataStructureCache::class)->getDataClass($objectDefinition::class);
+
+    expect(isset(invade($newDataClass->properties['string']->cast)->cast))->toBeFalse();
+});