Fix 792

Author: rubenvanassche

src/Normalizers/Normalized/NormalizedModel.php

@@ -34,7 +34,7 @@ public function getProperty(string $name, DataProperty $dataProperty): mixed
 
     protected function initialize(Model $model): void
     {
-        $this->properties = $model->withoutRelations()->toArray();
+        $this->properties = $model->attributesToArray();
 
         foreach ($model->getDates() as $key) {
             if (isset($this->properties[$key])) {

tests/Fakes/Models/FakeModel.php

@@ -47,6 +47,11 @@ public function performanceHeavyAccessor(): Attribute
         return Attribute::get(fn () => throw new Exception('This accessor should not be called'));
     }
 
+    public function getAccessorUsingRelationAttribute(): string
+    {
+        return $this->fakeNestedModels->first()->string;
+    }
+
     protected static function newFactory()
     {
         return FakeModelFactory::new();

tests/Normalizers/ModelNormalizerTest.php

@@ -1,5 +1,6 @@
 <?php
 
+use Illuminate\Database\LazyLoadingViolationException;
 use Illuminate\Support\Facades\DB;
 use Spatie\LaravelData\Attributes\DataCollectionOf;
 use Spatie\LaravelData\Attributes\LoadRelation;
@@ -197,3 +198,34 @@
 
     expect($data)->oldAccessor->toEqual($model->old_accessor);
 });
+
+it('can create a data property for a model attribute which fetches a relation that is loaded and it will not trigger a lazy loading exception', function () {
+    $dataClass = new class ('') extends Data {
+        public function __construct(public string $accessor_using_relation)
+        {
+        }
+    };
+
+    $model = FakeModel::factory()->create();
+    FakeNestedModel::factory()->for($model)->create();
+
+    $freshModel = FakeModel::query()->first();
+
+    $freshModel->preventsLazyLoading = true;
+
+    expect(function () use ($dataClass, $freshModel) {
+        $freshModel->append('accessorUsingRelation');
+
+        $dataClass::from($freshModel);
+    })->toThrow(LazyLoadingViolationException::class);
+
+    $freshModel = $freshModel
+        ->load('fakeNestedModels')
+        ->append('accessorUsingRelation');
+
+    $data = $dataClass::from($freshModel);
+
+    expect($freshModel)
+        ->accessor_using_relation
+        ->toEqual($data->accessor_using_relation);
+});