Inconsistent file naming behaviour local vs s3

[ryanmortier]

I've built a simple file uploading example to learn the intricacies of AWS/S3.

I'm using Livewire and while I'm storing my media in S3, I've toyed with both local and S3 for the temporary upload location.

In doing so, I've noticed that when using the local file system for the temporary upload that the file name after storing the file in the media disk is the actual name of the file rather than some random string/hash. However, when using S3 as the temporary upload location, the file name is a random string/hash.

I know there are security implications when storing files as the original file names on local storage but perhaps this isn't an issue since it's still being stored on S3 but I'm curious why this behaviour is happening still.

For example when using S3 for both temporary uploads and the media disk:

    public function save(): void
    {
        $this->validate();

        Auth::user()
            ->addMediaFromDisk($this->photo->getRealPath(), 's3')
            ->usingName($this->photo->getClientOriginalName())
            ->toMediaCollection('photos');

        $this->reset('photo');
    }

---

For example when using local for the temporary uploads and S3 as the media disk:

    public function save(): void
    {
        $this->validate();

        Auth::user()
            ->addMedia($this->photo)
            ->toMediaCollection('photos');

        $this->reset('photo');
    }

[ryanmortier]

After looking into this more, it appears that storing the file as its original name is the default behaviour and it's because the addMediaFromDisk() method is now taking the temporary file name and assuming it's the uploaded file's original name.

The problem though is that using addMedia() method doesn't work if using S3 as the temporary upload location and alternatively doing ->addMediaFromDisk($this->photo, 's3') doesn't work either.

Do you suggest any workarounds?

[timgavin]

Why not just rename the photo when adding it? I use a random 12 character string and it works great.

auth()->user()
    ->addMedia($this->photo)
    ->usingName(str()->random(12))
    ->toMediaCollection('photos');