feat(speckleifc): Added speckleifc to this repo #433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #433 +/- ##
=======================================
Coverage 90.01% 90.01%
=======================================
Files 130 130
Lines 6100 6100
=======================================
Hits 5491 5491
Misses 609 609 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
gjedlicska
requested changes
Jul 11, 2025
| from specklepy.objects import Base | ||
|
|
||
|
|
||
| class ImportJob: |
There was a problem hiding this comment.
just nitpicking, but unless there is something very specific case against it, i'd recommend using the dataclass way of defining things
|
only minor changes requested @JR-Morgan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied the
speckleifcsource code from specklesystems/speckleifc as a folder undersrcalong sidespecklepyandspeckle_automate