Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback for “Vanilla Client” #318

Open
tacone opened this issue Nov 26, 2024 · 1 comment
Open

Feedback for “Vanilla Client” #318

tacone opened this issue Nov 26, 2024 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@tacone
Copy link

tacone commented Nov 26, 2024

Hey there. Was just reading your documentation:

rspc will generally use a GET request for queries and POST request for mutations however this isn't guaranteed.

This looks a bit scary, you might want to clarify it a bit (at least state that a GET will never be used for mutations) :)

@oscartbeaumont
Copy link
Member

Very fair. It's definitely not intended to say that mutations will ever be done over GET, it was intended for queries potentially being done over POST such as how GraphQL commonly works although that isn't currently supported.

We can probally just remove the whole sentence though because i'm not sure it's actually something that needs to be mentioned.

@oscartbeaumont oscartbeaumont added the documentation Improvements or additions to documentation label Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Development

No branches or pull requests

2 participants