Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies/externals/GoogleTest.cmake points to a repository that is not publicly available #2

Open
MatthewIreland opened this issue Sep 23, 2024 · 0 comments
Open

dependencies/externals/GoogleTest.cmake points to a repository that is not publicly available #2

MatthewIreland opened this issue Sep 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@MatthewIreland
Copy link
Contributor

MatthewIreland commented Sep 23, 2024 •
edited
Loading

This line points to a GitLab repository that is not publicly available. The consequence is an error if the user does not have access to this GitLab repository.

I suggest this is changed to point to https://github.com/google/googletest.git (default tag: main) and any projects requiring a custom fork of gtest can specify a non-default repository URL.
@MatthewIreland MatthewIreland added the bug Something isn't working label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MatthewIreland