Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hackery around keysize #45

Open
stephenmathieson opened this issue Feb 13, 2014 · 5 comments
Open

Remove hackery around keysize #45

stephenmathieson opened this issue Feb 13, 2014 · 5 comments

Comments

@stephenmathieson
Copy link
Member

Sophia has pushed an update which removes the need to size_t keysize = strlen(key) + 1. We should now be able to remove all of that ugly logic now :)

@jwerle
Copy link
Member

jwerle commented Feb 26, 2014

awesome, I'll fix this now

@stephenmathieson
Copy link
Member Author

an issue I can foresee: it's likely data stored by libsphia will no longer work if we make this change. :/

@jwerle
Copy link
Member

jwerle commented Feb 26, 2014

Hmm, so should we close this issue ?

@stephenmathieson
Copy link
Member Author

nah, i don't think so. let's not get stuck on an old (broken) version of sophia.

we haven't released a version of this yet, so nobody should really be effected.

@jwerle
Copy link
Member

jwerle commented Feb 26, 2014

What should we knock out to get the first release out ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants