Skip to content

Flaky test - TestAttestAgent/rate_limit_fails #5774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
rturner3 opened this issue Jan 14, 2025 · 0 comments · May be fixed by #6064
Open

Flaky test - TestAttestAgent/rate_limit_fails #5774

rturner3 opened this issue Jan 14, 2025 · 0 comments · May be fixed by #6064
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog

Comments

@rturner3
Copy link
Collaborator 

--- FAIL: TestAttestAgent (0.33s)
    --- FAIL: TestAttestAgent/rate_limit_fails (0.01s)
        service_test.go:3436: 
            	Error Trace:	/home/runner/work/spire/spire/pkg/server/api/agent/v1/service_test.go:3436
            	            				/home/runner/work/spire/spire/pkg/server/api/agent/v1/service_test.go:3175
            	Error:      	Received unexpected error:
            	            	EOF
            	Test:       	TestAttestAgent/rate_limit_fails
        server.go:123: Gracefully stopping gRPC server
        server.go:125: Server stopped
        server.go:127: Server serve returned <nil>
        server.go:119: Waiting for handlers to drain
        server.go:121: Handlers drained
FAIL
FAIL	github.com/spiffe/spire/pkg/server/api/agent/v1	0.919s

https://github.com/spiffe/spire/actions/runs/12777880767/job/35619626996?pr=5762
@rturner3 rturner3 added help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog labels Jan 14, 2025
@sorindumitru sorindumitru mentioned this issue Jan 24, 2025
Merged
c4rlo added a commit to c4rlo/spire that referenced this issue May 11, 2025
@c4rlo
TestAttestAgent: add debug logs
2a12909 
To helpt track down occasional test failures.

This flakeyness was reported previously in spiffe#5774 with improvements made
in spiffe#5815, but it is still happening.
c4rlo added a commit to c4rlo/spire that referenced this issue May 11, 2025
@c4rlo
TestAttestAgent: add debug logs
3c3c5e6 
To helpt track down occasional test failures.

This flakeyness was reported previously in spiffe#5774 with improvements made
in spiffe#5815, but it is still happening.

Signed-off-by: Carlo Teubner <[email protected]>
c4rlo added a commit to c4rlo/spire that referenced this issue May 11, 2025
@c4rlo
TestAttestAgent: fix flakeyness
a58fc0a 
This flakeyness was reported previously in spiffe#5774 with improvements made
in spiffe#5815, but was still happening.

Hopefully fix it, by not assuming that the gRPC Send() message must not
return an error; it is legitimately allowed to return io.EOF, in the
case where the server has returned an application-level error, which
we can then obtain via a Recv() call.

See https://pkg.go.dev/google.golang.org/grpc#ClientStream.SendMsg

Signed-off-by: Carlo Teubner <[email protected]>
c4rlo added a commit to c4rlo/spire that referenced this issue May 11, 2025
@c4rlo
TestAttestAgent: fix flakeyness
bac9b42 
This flakeyness was reported previously in spiffe#5774 with improvements made
in spiffe#5815, but was still happening.

Hopefully fix it, by not assuming that the gRPC Send() message must not
return an error; it is legitimately allowed to return io.EOF, in the
case where the server has returned an application-level error, which
we can then obtain via a Recv() call.

See https://pkg.go.dev/google.golang.org/grpc#ClientStream.SendMsg

Signed-off-by: Carlo Teubner <[email protected]>
@c4rlo c4rlo linked a pull request May 11, 2025 that will close this issue
Open
c4rlo added a commit to c4rlo/spire that referenced this issue Jun 5, 2025
@c4rlo
TestAttestAgent: fix flakeyness
13b4f21 
This flakeyness was reported previously in spiffe#5774 with improvements made
in spiffe#5815, but was still happening.

Hopefully fix it, by not assuming that the gRPC Send() message must not
return an error; it is legitimately allowed to return io.EOF, in the
case where the server has returned an application-level error, which
we can then obtain via a Recv() call.

See https://pkg.go.dev/google.golang.org/grpc#ClientStream.SendMsg

Signed-off-by: Carlo Teubner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Issues with this label are ready to start work but are in need of someone to do it priority/backlog Issue is approved and in the backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

golangci-lint: upgrade to v2 & fix flakey test c4rlo/spire
1 participant
@rturner3