Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does input X in degrade_dataset(...) has nan (missing values)? #1

Open
yezhengli-Mr9 opened this issue Jul 27, 2020 · 2 comments
Open

Comments

@yezhengli-Mr9
Copy link

yezhengli-Mr9 commented Jul 27, 2020

Hi Indro,
Does input X in degrade_dataset(...) possibly have nan (missing values, I mean the raw data has intrinsic missing values)?

If so, why mask_1d = np.ones(n) rather than mask_1d = #where X is not nan?

@spindro
Copy link
Owner

spindro commented Jul 30, 2020

Hi!
If you use degrade_dataset it is supposed that the raw data is perfect and you want to create missing values.
By the way, if your raw data has already some missing values, you can still use degrade_dataset to add some noise. In this case, you have to sum the original mask of missing values to the one produced by the function

If so, why 'mask_1d = np.ones(n)' rather than 'mask_1d = #where X is not nan'?

What I said before should clear also this point.

Let me know if it is ok now :)

@Coding511
Copy link

@spindro Is this code working for filling missing values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants