Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump SpinAppExecutor CRD version and automate updating CRD versions on release #242

Open
michelleN opened this issue May 23, 2024 · 1 comment

Comments

@michelleN
Copy link
Contributor

michelleN commented May 23, 2024

I believe this should have been done as part of the v0.2.0 release since there was a change to the SpinAppExecutor CRD and going forward we should outline when and how we should be bumping CRDs.

@michelleN michelleN changed the title bump version of spinapp CRD and automate updating CRD version on release bump SpinAppExecutor CRD version and automate updating CRD versions on release May 23, 2024
@endocrimes
Copy link
Contributor

endocrimes commented May 27, 2024

It's very uncommon for additive, non-breaking changes to require apiVersion bumps in kubernetes, and bumping them results in a lot of churn (code, documentation, end user configurations), so I'd like to avoid us bumping them in cases where we wouldn't need to write a conversion-webhook to safely work across them (mostly bigger schema changes) - We should probably test that the operator continues to function without new fields being present in API responses though (or that it at least fails gracefully-ish) because I don't think we've actively done that yet.

I'm not sure of many places where a written policy or validator for k8s api schema versioning exist tho 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants