Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to change default listening port for SpinApp? #326

Open
Mossaka opened this issue Oct 14, 2024 · 3 comments
Open

How to change default listening port for SpinApp? #326

Mossaka opened this issue Oct 14, 2024 · 3 comments

Comments

@Mossaka
Copy link
Member

Mossaka commented Oct 14, 2024

It seems to me that the SPIN_HTTP_LISTEN_ADDR is hard-coded in the deployment.go (i.e. https://github.com/spinkube/spin-operator/blob/main/internal/controller/deployment.go#L121-L124). Suggest: maybe we should add port to SpinAppSpec to control what listening port the app is listening on?

@endocrimes
Copy link
Contributor

There's a little historical context in #266 - I'm curious as to what led to wanting to change the port here? (I've been thinking about changing it to non-80 as part of running as non-root by default at some point, but haven't come across a reason as to why you'd want to actively configure it yet?)

@Mossaka
Copy link
Member Author

Mossaka commented Oct 14, 2024

The motivation is to add multi-container support #325 which may take port 80.

@endocrimes
Copy link
Contributor

endocrimes commented Oct 14, 2024

hmm I think for a first stab we can require them not use p80 (if we wanna change ports I'd like us to think about the broader network topology / runAsNonRoot / ... all the other bits, before we just give folks a port flag that we need to migrate/drop later).

That kinda ties into the Nginx example (where if you want to do a secondary ingress thing, you'd need more control over the overall network topology and service binding for it to be effective).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants