Skip to content
This repository was archived by the owner on Apr 15, 2022. It is now read-only.

Commit a6e3032

Browse files
Epsteinedriggers
authored andcommitted
DBAAS-2961: allow for mlmanager e-e test in testing mode (#27)
* DBAAS-2961: allow for mlmanager e-e test in testing mode * adding amrit as codeowner
1 parent 3d3b6bf commit a6e3032

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

CODEOWNERS

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
#Global-Reviewers
22

33
#* @splicemachine/splice-cloudops
4-
* @bklo94 @Ben-Epstein @edriggers @jhoule-splice @jramineni @njnygaard @patricksplice @splicemaahs @troysplice
4+
* @bklo94 @Ben-Epstein @edriggers @jhoule-splice @jramineni @njnygaard @patricksplice @splicemaahs @troysplice @abaveja313

splicemachine/ml/management.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@
1515
from requests.auth import HTTPBasicAuth
1616

1717

18-
def get_pod_uri(pod, port, pod_count=0, testing=False):
18+
def get_pod_uri(pod, port, pod_count=0, _testing=False):
1919
"""
2020
Get address of MLFlow Container for Kubernetes
2121
"""
2222

23-
if testing:
23+
if _testing:
2424
return "http://{pod}:{port}".format(pod=pod, port=port) # mlflow docker container endpoint
2525

2626
try:
@@ -129,8 +129,9 @@ def __init__(self, splice_context, tracking_uri=None, _testing=False):
129129
will be assumed as a file store. Defaults to
130130
MLFlow DC/OS Pod
131131
"""
132+
self._testing = _testing
132133
if not tracking_uri:
133-
server_endpoint = get_pod_uri("mlflow", "5001", testing=_testing)
134+
server_endpoint = get_pod_uri("mlflow", "5001", _testing=_testing)
134135
else:
135136
server_endpoint = tracking_uri
136137

@@ -731,7 +732,7 @@ def _initiate_job(self, payload, endpoint):
731732
" Please run manager.login_director(username, password)"
732733
)
733734
request = requests.post(
734-
get_pod_uri('mlflow', 5003) + endpoint,
735+
get_pod_uri('mlflow', 5003, _testing=self._testing) + endpoint,
735736
auth=self._basic_auth,
736737
json=payload,
737738

0 commit comments

Comments
 (0)