Skip to content
This repository was archived by the owner on Apr 15, 2022. It is now read-only.

Commit e2740bf

Browse files
author
sergioferragut
committed
upper case for all schema name table name parameters to address DB case
1 parent 96aaad8 commit e2740bf

File tree

1 file changed

+22
-0
lines changed

1 file changed

+22
-0
lines changed

splicemachine/features/feature_store.py

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -437,6 +437,10 @@ def create_feature_set(self, schema_name: str, table_name: str, primary_keys: Di
437437
:param desc: The (optional) description
438438
:return: FeatureSet
439439
"""
440+
# database stores object names in upper case
441+
schema_name = schema_name.upper()
442+
table_name = table_name.upper()
443+
440444
self._validate_feature_set(schema_name, table_name)
441445
fset = FeatureSet(splice_ctx=self.splice_ctx, schema_name=schema_name, table_name=table_name,
442446
primary_keys=primary_keys,
@@ -495,6 +499,9 @@ def create_feature(self, schema_name: str, table_name: str, name: str, feature_d
495499
:return: Feature created
496500
"""
497501
self.__validate_feature_data_type(feature_data_type)
502+
# database stores object names in upper case
503+
schema_name = schema_name.upper()
504+
table_name = table_name.upper()
498505
if self.splice_ctx.tableExists(schema_name, table_name):
499506
raise SpliceMachineException(f"Feature Set {schema_name}.{table_name} is already deployed. You cannot "
500507
f"add features to a deployed feature set.")
@@ -643,6 +650,10 @@ def describe_feature_set(self, schema_name: str, table_name: str) -> None:
643650
:param table_name: feature set table name
644651
:return: None
645652
"""
653+
# database stores object names in upper case
654+
schema_name = schema_name.upper()
655+
table_name = table_name.upper()
656+
646657
fset = self.get_feature_sets(_filter={'schema_name': schema_name, 'table_name': table_name})
647658
if not fset: raise SpliceMachineException(
648659
f"Feature Set {schema_name}.{table_name} not found. Check name and try again.")
@@ -727,6 +738,10 @@ def _retrieve_training_set_metadata_from_deployement(self, schema_name: str, tab
727738
:param table_name: model table name
728739
:return:
729740
"""
741+
# database stores object names in upper case
742+
schema_name = schema_name.upper()
743+
table_name = table_name.upper()
744+
730745
sql = SQL.get_deployment_metadata.format(schema_name=schema_name, table_name=table_name)
731746
deploy_df = self.splice_ctx.df(sql).collect()
732747
cnt = len(deploy_df)
@@ -741,6 +756,10 @@ def display_model_feature_drift(self, schema_name: str, table_name: str):
741756
:param table_name: name of the model table
742757
:return: None
743758
"""
759+
# database stores object names in upper case
760+
schema_name = schema_name.upper()
761+
table_name = table_name.upper()
762+
744763
metadata = self._retrieve_training_set_metadata_from_deployement(schema_name, table_name)
745764
if not metadata:
746765
raise SpliceMachineException(f"Could not find deployment for model table {schema_name}.{table_name}") from None
@@ -763,6 +782,9 @@ def display_model_drift(self, schema_name: str, table_name: str, time_intervals:
763782
:param end_time: if specified, filters to only show predictions occurring before this date/time
764783
:return: None
765784
"""
785+
# database stores object names in upper case
786+
schema_name = schema_name.upper()
787+
table_name = table_name.upper()
766788
# set default timeframe if not specified
767789
if not start_time:
768790
start_time = datetime(1900, 1, 1, 0, 0, 0)

0 commit comments

Comments
 (0)