From 109e05e89069a9eb5cb1a47aee99bb7054bfb45d Mon Sep 17 00:00:00 2001
From: Jina Jain <jjain@splunk.com>
Date: Tue, 15 Oct 2024 17:06:01 -0700
Subject: [PATCH] chore: fix github outputs

---
 .github/workflows/draft-release.yaml | 4 ++--
 .github/workflows/test.yaml          | 2 +-
 scripts/prepare-release.sh           | 8 ++++----
 3 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/.github/workflows/draft-release.yaml b/.github/workflows/draft-release.yaml
index 0bd2864..62a1723 100644
--- a/.github/workflows/draft-release.yaml
+++ b/.github/workflows/draft-release.yaml
@@ -64,8 +64,8 @@ jobs:
         if: ${{ steps.prepare_release.outputs.NEEDS_UPDATE == 1 && steps.check_if_pr_open.outputs.NEEDS_PR == 1 }}
         uses: peter-evans/create-pull-request@5e914681df9dc83aa4e4905692ca88beb2f9e91f # v7.0.5
         with:
-          commit-message: Prepare release v${{ steps.prepare_release.outputs.NEW_CHART_VERSION }}
-          title: "chore: Prepare release v${{ steps.prepare_release.outputs.NEW_CHART_VERSION }}"
+          commit-message: Prepare chart release ${{ steps.prepare_release.outputs.NEW_CHART_VERSION }}
+          title: "chore: Prepare chart release ${{ steps.prepare_release.outputs.NEW_CHART_VERSION }}"
           body: |
             Description
             - Release chart version ${{ steps.prepare_release.outputs.NEW_CHART_VERSION }}
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
index 25ff01f..d8fa488 100644
--- a/.github/workflows/test.yaml
+++ b/.github/workflows/test.yaml
@@ -37,7 +37,7 @@ jobs:
         run: |
           changed=$(ct list-changed --config=ct.yaml)
           if [[ -n "$changed" ]]; then
-            echo "::set-output name=changed::true"
+            echo "changed=true" >> "$GITHUB_OUTPUT"
           fi
 
       - name: Run chart-testing (lint)
diff --git a/scripts/prepare-release.sh b/scripts/prepare-release.sh
index 85d7387..1b6ac4c 100755
--- a/scripts/prepare-release.sh
+++ b/scripts/prepare-release.sh
@@ -30,14 +30,14 @@ NEW_APP_VERSION=${APP_VERSION:-$LATEST_RUNNER_TAG}
 if [ "$CURRENT_APP_VERSION" == "$NEW_APP_VERSION" ]; then
   echo "Runner image tag is already up to date (appVersion $CURRENT_APP_VERSION)."
   if [[ -n "${GITHUB_ACTIONS-}" ]]; then
-    echo "NEEDS_UPDATE=0" >> "$GITHUB_ENV"
+    echo "NEEDS_UPDATE=0" >> "$GITHUB_OUTPUT"
   fi
   exit 0
 else
   echo "Runner image tag is not up to date. Current appVersion is $CURRENT_APP_VERSION and the new appVersion is $NEW_APP_VERSION."
   if [[ -n "${GITHUB_ACTIONS-}" ]]; then
-    echo "NEEDS_UPDATE=1" >> "$GITHUB_ENV"
-    echo "NEW_APP_VERSION=$NEW_APP_VERSION" >> "$GITHUB_ENV"
+    echo "NEEDS_UPDATE=1" >> "$GITHUB_OUTPUT"
+    echo "NEW_APP_VERSION=$NEW_APP_VERSION" >> "$GITHUB_OUTPUT"
   fi
 fi
 
@@ -52,5 +52,5 @@ echo "Updating the chart version to $NEW_CHART_VERSION"
 NEW_CHART_VERSION=${NEW_CHART_VERSION} yq eval -i '.version = strenv(NEW_CHART_VERSION)' ${CHART_YAML_PATH}
 
 if [[ -n "${GITHUB_ACTIONS-}" ]]; then
-  echo "NEW_CHART_VERSION=$NEW_CHART_VERSION" >> "$GITHUB_ENV"
+  echo "NEW_CHART_VERSION=$NEW_CHART_VERSION" >> "$GITHUB_OUTPUT"
 fi