Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capacity Upgrade shop's items are cleared when Item Functionality instead of Item Pool is Hard+ #794

Open
tcprescott opened this issue Feb 20, 2020 · 0 comments
Labels

Comments

@tcprescott
Copy link
Collaborator

tcprescott commented Feb 20, 2020

Options page says the capacity upgrades should be removed with a Hard+ item pool, but instead is being removed with the Item Functionality setting: https://alttpr.com/en/options#item_pool

switch ($this->config('item.functionality')) {
case 'expert':
$this->config['rom.HardMode'] = 2;
break;
case 'hard':
$this->config['rom.HardMode'] = 1;
}

switch ($world->config('rom.HardMode', 0)) {
case 1:
case 2:
case 3:
$world->getShop("Capacity Upgrade")->clearInventory();
$world->getShop("Dark World Potion Shop")->addInventory(1, Item::get('Nothing', $world), 0);
$world->getShop("Dark World Forest Shop")->addInventory(0, Item::get('Nothing', $world), 0);
$world->getShop("Dark World Lumberjack Hut Shop")->addInventory(1, Item::get('Nothing', $world), 0);
$world->getShop("Dark World Outcasts Shop")->addInventory(1, Item::get('Nothing', $world), 0);
$world->getShop("Dark World Lake Hylia Shop")->addInventory(1, Item::get('Nothing', $world), 0);
break;
}

We just need to instead have this driven off the item_pool setting instead of using rom.HardMode, or update documentation on the site.

@tcprescott tcprescott added the bug label Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant