Add Java 17 to GHA setup (#4659)

Author: clairemcginty

.github/workflows/it-tests.yml

@@ -31,6 +31,7 @@ jobs:
         java:
           - 8
           - 11
+          - 17
         scala:
           - 2.12.17
           - 2.13.8

.github/workflows/release.yml

@@ -12,11 +12,11 @@ jobs:
           fetch-depth: 0
       - name: cache SBT
         uses: coursier/cache-action@v6
-      - name: Java 11 setup
+      - name: Java 17 setup
         uses: actions/setup-java@v3
         with:
           distribution: temurin
-          java-version: 11
+          java-version: 17
       - uses: olafurpg/setup-gpg@v3
       - name: Publish ${{ github.ref }}
         run: sbt ci-release

.github/workflows/tests.yml

@@ -29,6 +29,7 @@ jobs:
         java:
           - 8
           - 11
+          - 17
         scala:
           - 2.12.17
           - 2.13.8

build.sbt

@@ -306,7 +306,8 @@ val commonSettings = Def
       )
     ),
     mimaSettings,
-    formatSettings
+    formatSettings,
+    java17Settings
   )
 
 lazy val publishSettings = Def.settings(
@@ -452,6 +453,20 @@ def splitTests(tests: Seq[TestDefinition], filter: Seq[String], forkOptions: For
   }
 }
 
+lazy val java17Settings = sys.props("java.version") match {
+  case v if v.startsWith("17.") =>
+    Seq(
+      Test / fork := true,
+      Test / javaOptions ++= Seq(
+        "--add-opens",
+        "java.base/java.util=ALL-UNNAMED",
+        "--add-opens",
+        "java.base/java.lang.invoke=ALL-UNNAMED"
+      )
+    )
+  case _ => Seq()
+}
+
 lazy val root: Project = Project("scio", file("."))
   .settings(commonSettings)
   .settings(

scio-test/src/test/scala/com/spotify/scio/coders/CoderTest.scala

@@ -211,10 +211,9 @@ final class CoderTest extends AnyFlatSpec with Matchers {
       cw.runWithImplicit
       throw new Throwable("Is expected to throw when passing implicit from outer class")
     } catch {
-      case e: NullPointerException =>
-        // In this case outer field is called "$cw" and it is hard to wrap it with proper exception
-        // so we allow it to fail with NullPointerException
-        e.getMessage should be(null)
+      case _: NullPointerException =>
+      // In this case outer field is called "$cw" and it is hard to wrap it with proper exception
+      // so we allow it to fail with NullPointerException
     }
 
     {