Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading to the new version with Spree 3.1 #352

Open
gaqzi opened this issue Jul 19, 2016 · 3 comments
Open

Upgrading to the new version with Spree 3.1 #352

gaqzi opened this issue Jul 19, 2016 · 3 comments
Assignees
Labels

Comments

@gaqzi
Copy link

gaqzi commented Jul 19, 2016

When upgrading to the 3.1 stable branch we discovered that the extension now has some javascript parts. It took a while to figure that out as there's no changelog and no upgrade instructions to start including the javascript.

As well we discovered that when you have an extension that has modified the UI and uses the hooks of the old rendered-in-place links then you'll also have to enable the javascript in the extension's dummy app. While straightforward it took a bit of exploring to figure out. In case it's useful for someone else:

task :test_app do
  # …
  File.open('vendor/assets/javascripts/spree/frontend/all.js', 'a') { |f| f.write "//= require spree/frontend/spree_auth\n" }
  puts `bundle exec rake assets:precompile`
end
@damianlegawiec
Copy link
Member

Thanks @gaqzi for pointing this out - docs needs to be more precise on this.

@damianlegawiec damianlegawiec self-assigned this Jul 19, 2016
@gaqzi
Copy link
Author

gaqzi commented Jul 19, 2016

@damianlegawiec just out of curiosity, what is the reason for having it as Javascript? I have my theory but would be nice to know :)

@damianlegawiec
Copy link
Member

@gaqzi ease of implementing full page caching and keeping it the same as cart preview :) Frontend actually isn't our top priority (API & Admin Panel are) as it's the part that is most frequently swapped entirely for something custom (and that's a good thing).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants