Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selecting HTTP client builders for Eureka Client #4382

Open
OlgaMaciaszek opened this issue Dec 2, 2024 · 0 comments
Open

Fix selecting HTTP client builders for Eureka Client #4382

OlgaMaciaszek opened this issue Dec 2, 2024 · 0 comments

Comments

@OlgaMaciaszek
Copy link
Collaborator

Currently, if there's a builder bean for HTTP client (RestClient.Builder, WebClient.Builder, etc.) created by the user, it's used for creating the client used for communication with Eureka. The problem with this approach is that it's not readily visible for the users and we may end up using builder beans with a setup that was not intended by the users to be used for communicating with Eureka (for example, a @LoadBalanced RestClient.Builder). Consider switching to an approach where if there's a builder identified by the user for this specific purpose (for example, by a specific supplier function or interface), it's used, if not, we create our own and use available configurers/customisers on it to make sure the Boot-provided capabilities, such as metrics support are there.

See:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant