Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop extending from BindableRuntimeHintsRegistrar #44254

Open
snicoll opened this issue Feb 13, 2025 · 0 comments · May be fixed by #44266
Open

Stop extending from BindableRuntimeHintsRegistrar #44254

snicoll opened this issue Feb 13, 2025 · 0 comments · May be fixed by #44266
Labels
type: task A general task
Milestone
3.3.x

Comments

@snicoll
Copy link
Member

snicoll commented Feb 13, 2025 •
edited
Loading

We have this pattern where we extend BindableRuntimeHintsRegistrar to register binding for a class. It's a bit confusing, the class should implement RuntimeHintsRegistrar and call the public factory method instead
@snicoll snicoll added the type: task A general task label Feb 13, 2025
@snicoll snicoll added this to the 3.3.x milestone Feb 13, 2025
@ngocnhan-tran1996 ngocnhan-tran1996 linked a pull request Feb 13, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: task A general task
Projects
None yet
Milestone
3.3.x
Development

Successfully merging a pull request may close this issue.

Implement RuntimeHintsRegistrar ngocnhan-tran1996/spring-boot
1 participant
@snicoll