PR: Show changelog after updates (Update manager)#25647
PR: Show changelog after updates (Update manager)#25647ccordoba12 merged 8 commits intospyder-ide:masterfrom
Conversation
d4335f3 to
4e1d826
Compare
- Also, emit signal in that case so other plugins can react to updates. - This is only done for the standalone installers.
Also, fix dialog's title when showing changelog.
4e1d826 to
33156fa
Compare
| # Note: We only do this for the standalone installers because we can | ||
| # reliably detect updates and users can't easily go back to previous | ||
| # versions with them. | ||
| if is_conda_based_app(): |
There was a problem hiding this comment.
@dalthviz, please check if this logic is correct (by manually testing the installer from this PR) in the following scenarios:
- We shouldn't show the changelog when Spyder is started for the first time (i.e. with clean settings) nor the next time after that.
- If Spyder doesn't have clean settings (i.e. it was started before, you can simulate that by clearing our settings and starting the 6.1.2 installer), then we should show the changelog when the installer from this branch is launched.
- We shouldn't show the changelog the next time Spyder is started after the previous scenario.
There was a problem hiding this comment.
@ccordoba12 gave a check to the cases above, locally on Windows using the installer from this PR, and seems to me that things are working as expected 👍
However, one thing I noticed (at least on my Windows setup) is that the changelog shows a scrollbar which doesn't follow the theme style. Shouldn't the scrollbar follow a dark style (when using the dark theme) like for example with the Help or Online Help panes:
There was a problem hiding this comment.
gave a check to the cases above, locally on Windows using the installer from this PR, and seems to me that things are working as expected 👍
Great!
However, one thing I noticed (at least on my Windows setup) is that the changelog shows a scrollbar which doesn't follow the theme style.
Good catch!
Shouldn't the scrollbar follow a dark style (when using the dark theme) like for example with the Help or Online Help panes
I'll ask Andres to address that after merging this PR.
|
@dalthviz, please approve this PR so I can merge it if you agree with it. |
|
@meeseeksdev please backport to 6.x |
|
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
Description of Changes
Help > Show changelogmenu entry in case users want to check the changelog again.markdown-it-pyas a new dependency to render the changelog's markdown to html (although it was already a transitive one).Issue(s) Resolved
Fixes #
Affirmation
By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.
I certify the above statement is true and correct: @ccordoba12