Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable qr code import #208

Open
alexhauser opened this issue Jun 1, 2020 · 14 comments
Open

Enable qr code import #208

alexhauser opened this issue Jun 1, 2020 · 14 comments
Assignees
Labels
client Affects the Client project enhancement New feature or request
Milestone

Comments

@alexhauser
Copy link
Member

Description:

Enable importing a SQRL identity by scanning its QR code using the system's default web cam / capture device.

I'm currently working on this one, @josegomez.

@alexhauser alexhauser added enhancement New feature or request client Affects the Client project labels Jun 1, 2020
@alexhauser alexhauser added this to the v0.1.3.0-beta milestone Jun 1, 2020
@alexhauser alexhauser self-assigned this Jun 1, 2020
@josegomez
Copy link
Collaborator

Cool!

@alexhauser
Copy link
Member Author

@josegomez, short status report:

The whole thing started working flawlessly on Windows in no time:

Then, guess what?! I began testing on Linux and macOS and everything started falling apart. 😆

@josegomez
Copy link
Collaborator

yeah... linux our old "friend" @alexhauser LoL
Let me know if you need a hand. I was looking for something todo but frankly the open issues other than the one you are working on are either not our problem or non fixable.

@alexhauser
Copy link
Member Author

alexhauser commented Jun 12, 2020

I don't know... I'm currently using OpenCVSharp for capturing frames from the webcam, but I have problems getting it running on Linux and haven't even tried macOS, since we have a general libgdiplus problem there (even with mono-libgdiplus installed our qr code import/export code fails at the moment - see dotnet/runtime#27200).

I am leaning towards creating our own platform specific implementations for captruring frames from a video device (using our proven Interface / Implementation model) and coding everything ourselves instead of relying on heavyweight and fragile external libraries.

If that is something that sparks your interest (e.g. writing the Linux/macOS implementation for that), be my guest! 😁

@josegomez
Copy link
Collaborator

hhaha nothing sounds more exciting than writing platform specific stuff. I dream of fighting with Linux and Mac in Particular
All joking aside I don't mind so if this is the way you think we should go throw me an interface and I'll take a crack at it.

@alexhauser
Copy link
Member Author

Cool, Jose! 👏

However, you may want to take a look at the current state of affairs first and evaluate yourself, since I might be overreacting ;-)

You could checkout the import_qr branch on my fork at https://github.com/alexhauser/SQRLDotNetClient and poke around a little if you like.

@josegomez
Copy link
Collaborator

@alexhauser i'm still here sorry I've been awol, life has gotten in the way but this is still in my #TODO!

@alexhauser
Copy link
Member Author

No worries @josegomez, we're absolutely not in a hurry!

@dxcSithLord
Copy link

PyImageSearch has several blogs on QR detection code and images - have a look at this post, using Python, but the algorithm should be the same in .net:
https://www.pyimagesearch.com/2018/05/21/an-opencv-barcode-and-qr-code-scanner-with-zbar/

@alexhauser
Copy link
Member Author

@dxcSithLord, thanks for the input. However, "the algorightm" is not the issue here. I know how to use the OpenCV library, and detecting barcodes is not a problem, either. The problem is, that the .NET port of the OpenCV library that we rely on for .NET, while working properly on Windows, currently fails to work on Linux and macOS.

@josegomez
Copy link
Collaborator

@alexhauser are we just waiting to finish this to release the next version I suppose? I'll try to work some on it this week. The ole J O B has been relentless lately.

@alexhauser
Copy link
Member Author

Yes @josegomez, but we can easily release without this one if we want. It's only an enhancement after all, nothing important! Your call! 😊

@josegomez
Copy link
Collaborator

@alexhauser we can wait is not like anyone is banging on our doors to finish this... I'm pretty sure unless a miracle happens SQRL in general is DOA :'(

@alexhauser
Copy link
Member Author

Amen, @josegomez.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Affects the Client project enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants