Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linux] system tray icon cannot be smaller than a fixed size at 32x32 pixels #88

Open
dreamcat4 opened this issue Apr 4, 2020 · 5 comments
Labels
client Affects the Client project enhancement New feature or request linux Linux wontfix This will not be worked on

Comments

@dreamcat4
Copy link

This is an issue on some linux system trays because the SQRL icon is imposing a limit on the size of the task bar. Which in turn impinges on the title bar of windows and break the desktop layout.

This is especially true when the Desktop System Tray is configured to use 24px or 16px icon sizes... which are both smaller than 32px.

Looking at your code here it would appear that the system tray icon that sqirrel client is using is this one:

https://github.com/sqrldev/SQRLDotNetClient/blob/master/SQRLDotNetClientUI/Assets/SQRL_icon_normal_32.png

However it might be a better idea would be to instead use the SVG icon. For example:

https://github.com/sqrldev/SQRLDotNetClient/blob/master/SQRLDotNetClientUI/Assets/SQRL_icon_normal.svg

Which then will permit the desktop environment to do its own scaling of the icon properly. And without introducing any bitmap artefacting. This is expecially true when dealing with these smaller icon sizes.

Not sure how you create this system tray icon in your DotNet code. If it is in turn calling out to QT5 or GTK2 library. However I believe it should be possible to rectify this.

@josegomez josegomez added enhancement New feature or request installer Affects the Installer project labels Apr 29, 2020
@alexhauser alexhauser added client Affects the Client project and removed installer Affects the Installer project labels Apr 29, 2020
@josegomez josegomez added the linux Linux label Apr 29, 2020
@josegomez josegomez added the wontfix This will not be worked on label Jun 10, 2020
@josegomez
Copy link
Collaborator

Looked at this is, it is currently not possible due to several limitations. Wont fix for now.

@alexhauser
Copy link
Member

We have another report for this in the forums at https://sqrl.grc.com/threads/linux-testing-feedback.1109/post-9577, this time with a screenshot, I thought I would re-post it here just for future reference:

Screenshot from 2020-06-14 18_56_07

@josegomez, I guess the "limitations" you are taking about are due to us relying on third party code for the tray icon. Maybe we should think about writing our own notification icon implementation for Linux somewhere down the line, just like we did for Windows.

@josegomez
Copy link
Collaborator

I’ll look at this some more but yes the library we are using doesn’t allow us to use vectors

@alexhauser
Copy link
Member

How about querying the "correct" dimensions for the icon from the system before setting up the NotifyIcon and then just providing the properly scaled pixel image?

@josegomez
Copy link
Collaborator

That may be an option not even sure where to start with that but I’ll take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client Affects the Client project enhancement New feature or request linux Linux wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

3 participants