Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Use containerlab' node labels to tag launcher deployment #162

Open
hellt opened this issue Jul 11, 2024 · 1 comment
Open

FR: Use containerlab' node labels to tag launcher deployment #162

hellt opened this issue Jul 11, 2024 · 1 comment

Comments

@hellt
Copy link
Member

hellt commented Jul 11, 2024

https://containerlab.dev/manual/nodes/#labels

Besides the filtering/selection use case this would make it possible to create a special label format that would allow propagate certain labels to node selectors and/or tolerations.

The use case expressed here is to make sure that certain launcher pods could be scheduled to certain nodes using the nodeSelector.

Maybe node labels can be put to work for this use case.

@carlmontanari
Copy link
Contributor

taking the clab labels and just putting them on the launcher deployments (like srl1 labels go to srl1 deployment labels, ceos1 labels to go ceos1 deployment labels, etc.) is a great idea imo. should do that regardless.

the only way I see changing the node selector setup right now would be to breaking change it to make it like the resources field where its a map of nodename-->our scheduling object. obviously I am down to break things at any point and also we are 0.x so I extra dont care 😁 . but thats probably the only way I think adding this would make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants