Skip to content

refactor: load tools dynamically in ToolRegistry #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

refactor: load tools dynamically in ToolRegistry #1576

wants to merge 1 commit into from
+46 −27

Conversation

yordis
Copy link
Contributor

@yordis yordis commented Aug 3, 2025 •
edited
Loading

Circular Dependency Issue

  • The registry.ts file was using static imports for all tools
  • Some tools (like TaskTool) import from ../session, which imports ToolRegistry
  • This created a circular dependency chain: registry.ts → edit.ts → (indirectly) → session/index.ts → registry.ts
  • Static imports are evaluated at module load time, causing the initialization error

@yordis yordis marked this pull request as ready for review August 3, 2025 21:15
@yordis
Copy link
Contributor Author

yordis commented Aug 7, 2025

@thdxr any thoughts about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yordis