Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overrides for access-control.properties #692

Closed
maltesander opened this issue Jan 13, 2025 · 2 comments · Fixed by #721
Closed

Allow overrides for access-control.properties #692

maltesander opened this issue Jan 13, 2025 · 2 comments · Fixed by #721

Comments

@maltesander
Copy link
Member

maltesander commented Jan 13, 2025

The Trino operator currently only offers to override config.properties and node.properties.

JVM parameters will be overrideable after #677 is merged.

The log.properties can already be overridden https://docs.stackable.tech/home/stable/concepts/logging/#_custom_overrides. The missing part then is access-control.properties (which became more important after the proper OPA authorizer support).

@xeniape xeniape self-assigned this Mar 3, 2025
@xeniape xeniape moved this to Refinement: In Progress in Stackable Engineering Mar 3, 2025
@lfrancke lfrancke moved this to In Refinement in Stackable End-to-End Coordination Mar 5, 2025
@xeniape xeniape moved this from Refinement: In Progress to Development: In Progress in Stackable Engineering Mar 10, 2025
@xeniape xeniape moved this from In Refinement to In Progress in Stackable End-to-End Coordination Mar 10, 2025
@maltesander maltesander changed the title Allow overrides for log.properties and access-control.properties Allow overrides for access-control.properties Mar 12, 2025
@xeniape xeniape linked a pull request Mar 13, 2025 that will close this issue
@sbernauer sbernauer moved this from Development: In Progress to Development: Done in Stackable Engineering Mar 17, 2025
@lfrancke lfrancke moved this from In Progress to Done in Stackable End-to-End Coordination Mar 19, 2025
@lfrancke
Copy link
Member

Could you please add a snippet for the release notes and if we have a link to the docs

@lfrancke lfrancke moved this from Development: Done to Acceptance: In Progress in Stackable Engineering Mar 20, 2025
@maltesander
Copy link
Member Author

Its here in the docs https://docs.stackable.tech/home/nightly/trino/usage-guide/configuration/#_configuration_properties
but not here https://docs.stackable.tech/home/nightly/trino/usage-guide/overrides/#_configuration_overrides (which is kinda redundant).

Snippet:

The `access-control.properties` now can be overridden the same way as `config.properties` or `node.properties`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Acceptance: In Progress
Development

Successfully merging a pull request may close this issue.

4 participants