Skip to content

Commit be3c66e

Browse files
jproque-dellthathagarNilesh
authored andcommitted
Dell PowerFlex: Additionnal params for enabling self signed certificates
Initially before the change https://review.opendev.org/c/openstack/os-brick/+/810419 was merged to close the bug https://bugs.launchpad.net/os-brick/+bug/1929223, verify_cert was always set to False which can lead to security issues. It has been decided through this change that this option can be set to True or False based upon security requirements. This change introduced a regression failure as the value set to the option is not part of connection_properties. This patch adds additional params during initialization so that it can be carried over os-brick and get adequate REST API response. Closes-Bug: 1990136 Change-Id: I0d266a57f68221a3b1740a7376e152bb64cac729 (cherry picked from commit 82823ac) (cherry picked from commit 8794f84)
1 parent 4aa6590 commit be3c66e

File tree

2 files changed

+16
-0
lines changed

2 files changed

+16
-0
lines changed

cinder/volume/drivers/dell_emc/powerflex/driver.py

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -868,6 +868,12 @@ def _initialize_connection(self, vol_or_snap, connector, vol_size):
868868
connection_properties["scaleIO_volume_id"] = vol_or_snap.provider_id
869869
connection_properties["config_group"] = self.configuration.config_group
870870
connection_properties["failed_over"] = self._is_failed_over
871+
connection_properties["verify_certificate"] = (
872+
self._get_client().verify_certificate
873+
)
874+
connection_properties["certificate_path"] = (
875+
self._get_client().certificate_path
876+
)
871877

872878
if vol_size is not None:
873879
extra_specs = self._get_volumetype_extraspecs(vol_or_snap)
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
---
2+
fixes:
3+
- |
4+
Dell PowerFlex driver `bug #1998136
5+
<https://bugs.launchpad.net/cinder/+bug/1998136>`_:
6+
When using self signed certificates, the option
7+
sent to os-brick via the connection_properties was
8+
not correctly handled. It has now been fixed by
9+
adding the 'verify_certificate' and 'certificate_path'
10+
to the driver when initializing the connection.

0 commit comments

Comments
 (0)