Move repo additions to happen before do-release-upgrade

Moves the addition of new Ubuntu repositories to directly before the
call to do-release-upgrade. This ensures that any any failures after
that point are only due to the upgrade itself, and not due to missing
mounts (such as /tmp not being mounted).

Author: technowhizz

etc/kayobe/ansible/maintenance/ubuntu-upgrade.yml

@@ -54,18 +54,7 @@
       become: true
       when: file_status.stat.exists
 
-    # NOTE: We cannot use apt_repository here because definitions must exist within the standard repos.list
-    - name: Ensure Noble repo definitions exist in sources.list
-      ansible.builtin.blockinfile:
-        path: /etc/apt/sources.list
-        block: |
-          deb {{ stackhpc_repo_ubuntu_noble_url }} noble main restricted universe multiverse
-          deb {{ stackhpc_repo_ubuntu_noble_url }} noble-updates main restricted universe multiverse
-          deb {{ stackhpc_repo_ubuntu_noble_url }} noble-backports main restricted universe multiverse
-          deb {{ stackhpc_repo_ubuntu_noble_security_url }} noble-security main restricted universe multiverse
-      become: true
-
-    - name: Enusre /tmp is mounted with exec
+    - name: Ensure /tmp is mounted with exec
       ansible.posix.mount:
         path: /tmp
         opts: exec
@@ -81,6 +70,17 @@
       become: true
       when: inventory_hostname in groups['ceph']
 
+    # NOTE: We cannot use apt_repository here because definitions must exist within the standard repos.list
+    - name: Ensure Noble repo definitions exist in sources.list
+      ansible.builtin.blockinfile:
+        path: /etc/apt/sources.list
+        block: |
+          deb {{ stackhpc_repo_ubuntu_noble_url }} noble main restricted universe multiverse
+          deb {{ stackhpc_repo_ubuntu_noble_url }} noble-updates main restricted universe multiverse
+          deb {{ stackhpc_repo_ubuntu_noble_url }} noble-backports main restricted universe multiverse
+          deb {{ stackhpc_repo_ubuntu_noble_security_url }} noble-security main restricted universe multiverse
+      become: true
+
 - name: Upgrade hosts from Ubuntu Jammy 22.04 to Noble 24.04
   hosts: overcloud:infra-vms:seed:seed-hypervisor
   vars: