Skip to content

Require explicit setup step for secrets management #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmjb opened this issue Jun 3, 2025 · 0 comments
Open

Require explicit setup step for secrets management #615

dmjb opened this issue Jun 3, 2025 · 0 comments

Comments

@dmjb
Copy link
Member

dmjb commented Jun 3, 2025

Right now, the code will default to using the encrypted provider (i.e. the local provider) if no secrets provider is explicitly configured, and will prompt the user for a decryption password on the first use of any secrets functionality if none has been set up.

In order to support the API, we need to enforce a separate setup step which will prompt the user to select the type of secrets provider they want, and provide any details needed (the decryption password for the encrypted provider, and the token for the 1Password provider type). This should be exposed as a dedicated CLI command (e.g. thv secrets setup).

At minimum, we should treat it as an error to call a CLI command relating to secrets if the user has not set up a secrets provider. We may also want to consider calling the command automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant