ROX-30638: Remove tenant Route53 record management #2416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ludydoo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ludydoo
force-pushed
the
lcleroux/remove-route53-tenant-management
branch
from
412a4bb to
fa63a4c
Compare
ludydoo
force-pushed
the
lcleroux/remove-route53-tenant-management
branch
from
fa63a4c to
293a3b9
Compare
ludydoo
force-pushed
the
lcleroux/remove-route53-tenant-management
branch
from
dfd4452 to
51f6736
Compare
Contributor
Author
|
/retest |
3 similar comments
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Remove all Route53 DNS record management functionality from fleet manager since tenant DNS records are now managed by external DNS. Changes: - Remove Route53 methods from AWS client interface and implementation - Remove Route53 management methods from CentralService - Delete CentralRoutesCNAMEManager worker that handled DNS record creation - Remove Route53 configuration fields from AWS config - Add database migration to remove routes_creation_id field - Remove E2E DNS test utilities and update multicluster tests - Update affected tests and regenerate mocks 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
ludydoo
force-pushed
the
lcleroux/remove-route53-tenant-management
branch
from
53fcc94 to
044ab0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes Made
ListHostedZonesByNameInput,ChangeResourceRecordSets,GetChange)ChangeCentralCNAMErecords()andGetCNAMERecordStatus()methodsCentralRoutesCNAMEManagerworker entirelyroutes_creation_idfield from central requestsTest Plan
🤖 Generated with Claude Code