Skip to content

ROX-13227: add HTTP reachability check for Central UI host #2424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ROX-13227: add HTTP reachability check for Central UI host #2424

wants to merge 2 commits into from

Conversation

@ludydoo
Copy link
Contributor

@ludydoo ludydoo commented Sep 3, 2025

Summary

  • Add HTTP reachability check before marking Central as ready when using routes
  • Implement isCentralUIHostReachable function with 10-second timeout
  • Prevent premature ready state when Central UI is not accessible

Test plan

  • Verify Central UI reachability check works correctly in route-based deployments
  • Confirm timeout behavior when UI host is unreachable
  • Validate that Central waits for UI to be accessible before marking as ready

🤖 Generated with Claude Code

@ludydoo @claude
ROX-13227: add HTTP reachability check for Central UI host
7695a5b 
- Add HTTP check before marking Central as ready when using routes
- Implement isCentralUIHostReachable function with 10s timeout
- Check returns false if host is unreachable or returns error status
- Prevents premature ready state when Central UI is not accessible

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ludydoo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 3, 2025
@ludydoo @claude
ROX-13227: refactor UI reachability check with dependency injection
12cf049 
- Create CentralUIReachabilityChecker interface for testability
- Move HTTP reachability logic to HTTPCentralUIReachabilityChecker
- Add MockCentralUIReachabilityChecker for testing
- Inject checker dependency in reconciler for better testability
- Update tests to use mock checker to ensure consistent behavior

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <[email protected]>
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 3, 2025

@ludydoo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 12cf049 link true /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ludydoo