Skip to content

Conversation

@kovayur
Copy link
Contributor

@kovayur kovayur commented Nov 28, 2025

Description

Remove Parameter Store usages

  • Cleanup dev scripts secrets
  • Delete ClusterSecret store
  • Make emailsender use a Helm value for the AWS role ARN instead of ssm.
  • Delete osd-cluster-idp-setup.sh

Checklist (Definition of Done)

  • Unit and integration tests added
  • Added test description under Test manual
  • Documentation added if necessary (i.e. changes to dev setup, test execution, ...)
  • CI and all relevant tests are passing
  • Add the ticket number to the PR title if available, i.e. ROX-12345: ...
  • Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.
  • Add secret to app-interface Vault or Secrets Manager if necessary
  • RDS changes were e2e tested manually
  • Check AWS limits are reasonable for changes provisioning new resources

Test manual

TODO: Add manual testing efforts

# To run tests locally run:
make db/teardown db/setup db/migrate
make ocm/setup
make verify lint binary test test/integration

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kovayur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kovayur kovayur changed the title Remove Parameter Store usages ROX-32050: remove Parameter Store usages Nov 28, 2025
@kovayur kovayur changed the title ROX-32050: remove Parameter Store usages ROX-32050: Remove Parameter Store usages Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant