-
Notifications
You must be signed in to change notification settings - Fork 29
ROX-31971: update ubi and centos base images to 10 #2692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2692 +/- ##
==========================================
- Coverage 27.60% 27.38% -0.23%
==========================================
Files 95 95
Lines 5422 5427 +5
Branches 2523 2548 +25
==========================================
- Hits 1497 1486 -11
- Misses 3213 3214 +1
- Partials 712 727 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| - name: Generate coverage report | ||
| run: | | ||
| dnf install -y python-pip | ||
| dnf install -y python-pip gpg |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need gpg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first CI run in this PR had the codecov step failing with the message :
Error: The following required dependencies are missing: gpg
Please install these dependencies before using this action.
I suppose that gpg was available by default in stream9 ?
Description
We depend on clang version 1.19 to build the probe : with more recent versions, the produced code is deemed too complex by most verifiers. (cf. #2690 )
Centos stream9 does not ship 1.19 anymore, but stream10 does.
This PR updates the base images to 10 (ubi will have to be updated as will for the libc versions to be compatible).
Note regarding TBB:
TBB was updated to fix a compilation issue (a warning being turned into an error by -Werror). The fix upstream is a pragma to ignore the warning. Since we don't have private forks of our dependencies and this change is only intended for master, we are taking the risk of updating TBB.
Checklist
Testing
More testing : stackrox/stackrox#17983