Skip to content

Conversation

@ovalenti
Copy link
Contributor

@ovalenti ovalenti commented Nov 26, 2025

Description

We depend on clang version 1.19 to build the probe : with more recent versions, the produced code is deemed too complex by most verifiers. (cf. #2690 )
Centos stream9 does not ship 1.19 anymore, but stream10 does.

This PR updates the base images to 10 (ubi will have to be updated as will for the libc versions to be compatible).

Note regarding TBB:

TBB was updated to fix a compilation issue (a warning being turned into an error by -Werror). The fix upstream is a pragma to ignore the warning. Since we don't have private forks of our dependencies and this change is only intended for master, we are taking the risk of updating TBB.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Testing

More testing : stackrox/stackrox#17983

@ovalenti ovalenti self-assigned this Nov 26, 2025
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 27.38%. Comparing base (d759b32) to head (48c970b).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2692      +/-   ##
==========================================
- Coverage   27.60%   27.38%   -0.23%     
==========================================
  Files          95       95              
  Lines        5422     5427       +5     
  Branches     2523     2548      +25     
==========================================
- Hits         1497     1486      -11     
- Misses       3213     3214       +1     
- Partials      712      727      +15     
Flag Coverage Δ
collector-unit-tests 27.38% <ø> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovalenti ovalenti marked this pull request as ready for review November 26, 2025 19:41
@ovalenti ovalenti requested a review from a team as a code owner November 26, 2025 19:41
- name: Generate coverage report
run: |
dnf install -y python-pip
dnf install -y python-pip gpg
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need gpg?

Copy link
Contributor Author

@ovalenti ovalenti Nov 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first CI run in this PR had the codecov step failing with the message :

Error: The following required dependencies are missing: gpg
Please install these dependencies before using this action.

I suppose that gpg was available by default in stream9 ?

@ovalenti ovalenti merged commit 4ee8d1f into master Nov 27, 2025
88 of 91 checks passed
@ovalenti ovalenti deleted the ovalenti/use-stream10-ubi10 branch November 27, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants