-
Notifications
You must be signed in to change notification settings - Fork 29
ROX-31146: Reduce spam of Konflux PRs, releasers can approve #2693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
msugakov
wants to merge
6
commits into
master
Choose a base branch
from
misha/ROX-31146-reduce-konflux-spam
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ffaa929
Adjust codeowners
msugakov 52f9bba
Switch auto-approve away from `pull_request_target`
msugakov 921b48f
Restore formatting of the collector pipeline
msugakov 008095b
Add workflow for tagging human Konflux-maintainers for review
msugakov 7bca5a7
Correct articles in the comment
msugakov 1869384
Pin ubuntu version for consistency and stability
msugakov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| name: Tag more reviewers | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: | ||
| - review_requested | ||
|
|
||
| jobs: | ||
| tag-konflux-maintainers: | ||
| # We have lots of PR traffic from MintMaker (acting as `red-hat-konflux[bot]`), and so it's unsustainable to go | ||
| # through these emails every day. Therefore, the notifications are disabled for `konflux-maintainers-no-email` | ||
| # team that's set as owner in CODEOWNERS for the Konflux stuff. | ||
| # At the same time, we want to be notified when humans, not the bot, request reviews (which happens automatically | ||
| # again through CODEOWNERS) for the Konflux-related files. This job invites `konflux-maintainers` team for review | ||
| # for such cases. | ||
| if: | | ||
| github.event.requested_team.name == 'konflux-maintainers-no-email' && | ||
| github.event.pull_request.user.login != 'red-hat-konflux[bot]' | ||
| env: | ||
| GH_TOKEN: ${{ secrets.RHACS_BOT_GITHUB_TOKEN }} | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| - name: Tag Konflux Maintainers for review | ||
| run: | | ||
| exec gh api \ | ||
| --method POST \ | ||
| -H "Accept: application/vnd.github+json" \ | ||
| -H "X-GitHub-Api-Version: 2022-11-28" \ | ||
| "/repos/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/requested_reviewers" \ | ||
| --input - <<< '{ "team_reviewers": [ "konflux-maintainers" ] }' | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.