Skip to content

Conversation

@Molter73
Copy link
Collaborator

@Molter73 Molter73 commented Nov 14, 2025

Description

This is a required step to properly releasing fact. I don't want to forget about it and the change is simple enough, so the PR is just here to be merged when we need it.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

CI is enough.

@Molter73 Molter73 marked this pull request as ready for review November 14, 2025 12:11
@Molter73 Molter73 force-pushed the mauro/konflux/add-licenses branch from 4a13bac to 772eadc Compare November 14, 2025 16:06
Copy link
Contributor

@ovalenti ovalenti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We seem to also have dependencies with:

  • BSD (3-clause)
  • Zlib
  • ISC
  • Unicode-3.0

Is this PR ment to be exhaustive, or is it to satisfy some Konflux checks ?

@Molter73
Copy link
Collaborator Author

We seem to also have dependencies with:

* BSD (3-clause)

* Zlib

* ISC

* Unicode-3.0

Is this PR ment to be exhaustive, or is it to satisfy some Konflux checks ?

This is just to make konflux happy, but now I'm curious.

Doesn't collector have similar dependencies? And that is also Apache 2.0 license with the Falco CO-RE BPF code being dual MIT/GPL, so why is the dependencies on those important here? Are you suggesting we just ship every single one of those licenses?

@ovalenti
Copy link
Contributor

Are you suggesting we just ship every single one of those licenses?

For all the licenses requiring us to do so, this is my understanding that we should have the full text of each license and a file enumerating all the dependencies. Also the base image has itself a license.

Maybe we can start with this content and then iterate ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants