Skip to content

Conversation

@ovalenti
Copy link
Contributor

Description

Ownership changes are the first kind of event that has some specific attributes. This PR proposes to add a type-specific field to the event structure in the form of a union :

  • pros: the structure has the same size, whatever the type of event
  • cons: the structure is larger than required in avarage.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

@ovalenti ovalenti self-assigned this Nov 18, 2025
@ovalenti ovalenti force-pushed the ovalenti/ROX-30258-ownership-tracking branch from e94e169 to f0c48bd Compare November 18, 2025 10:58
@ovalenti ovalenti force-pushed the ovalenti/ROX-30258-ownership-tracking branch from f0c48bd to 194e1b1 Compare November 18, 2025 11:01
Extend the event type with a union of type specific structs.
missing user/group mapping to string representation
@ovalenti ovalenti force-pushed the ovalenti/ROX-30258-ownership-tracking branch from 39cf241 to f15de82 Compare November 18, 2025 15:45
@ovalenti ovalenti changed the base branch from main to mauro/ROX-30257/track-mode-change November 18, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants