chore(bench): measure heap in alert upsert test #17564
Conversation
Signed-off-by: Tomasz Janiszewski <[email protected]>
|
Images are ready for the commit at 847d887. To use with deploy scripts, first |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #17564 +/- ##
=======================================
Coverage 48.72% 48.73%
=======================================
Files 2728 2728
Lines 203127 203127
=======================================
+ Hits 98980 98989 +9
+ Misses 96399 96391 -8
+ Partials 7748 7747 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| runtime.GC() | ||
| runtime.ReadMemStats(&m) | ||
| maxHeap = max(maxHeap, m.HeapAlloc) | ||
| maxHeapObj = max(maxHeap, m.HeapObjects) |
There was a problem hiding this comment.
Can you make sure this set of steps has run once and the metrics have been collected as baseline before you move on to running the benchmark loop ?
Signed-off-by: Tomasz Janiszewski <[email protected]>
| b.ReportMetric(float64(maxHeap-startHeap), "max_heap_bytes") | ||
| b.ReportMetric(float64(maxHeapObj-startHeapObj), "max_heap_objects") |
There was a problem hiding this comment.
Looks good, but maybe consider also printing the startHeap and startHeapObj separately for reference?
There was a problem hiding this comment.
I'll check that as I remember logging in benchmark breaks benchstat
There was a problem hiding this comment.
I'll check that as I remember logging in benchmark breaks benchstat
5 participants
Description
This PR measures max heap bytes and objects in alert upsert benchmark.
User-facing documentation
Testing and quality
Automated testing
How I validated my change
change me!