Skip to content

Conversation

@tommartensen
Copy link
Contributor

Description

change me!

User-facing documentation

Testing and quality

  • the change is production ready: the change is GA, or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

  • added unit tests
  • added e2e tests
  • added regression tests
  • added compatibility tests
  • modified existing tests

How I validated my change

change me!

@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@rhacs-bot
Copy link
Contributor

rhacs-bot commented Oct 30, 2025

Images are ready for the commit at b95e848.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.10.x-211-gb95e848d52.

@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.72%. Comparing base (4a68181) to head (b95e848).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #17565      +/-   ##
==========================================
- Coverage   48.72%   48.72%   -0.01%     
==========================================
  Files        2728     2728              
  Lines      203127   203127              
==========================================
- Hits        98980    98976       -4     
- Misses      96399    96403       +4     
  Partials     7748     7748              
Flag Coverage Δ
go-unit-tests 48.72% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Please update the PR description and remove the placeholder 'change me!' sections so reviewers understand the intent of your tool and confirm any required documentation updates.
  • Add a preliminary check in the bump script to ensure the working directory is clean (no uncommitted changes), so you don’t accidentally overwrite in-flight work.
  • Consider validating that required dependencies (e.g., the GitHub CLI gh) are installed and configured before attempting to create or update PRs for a smoother developer experience.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Please update the PR description and remove the placeholder 'change me!' sections so reviewers understand the intent of your tool and confirm any required documentation updates.
- Add a preliminary check in the bump script to ensure the working directory is clean (no uncommitted changes), so you don’t accidentally overwrite in-flight work.
- Consider validating that required dependencies (e.g., the GitHub CLI `gh`) are installed and configured before attempting to create or update PRs for a smoother developer experience.

## Individual Comments

### Comment 1
<location> `tools/bump-apollo-ci/bump.sh:41` </location>
<code_context>
+    local version="$1"
+    local files
+
+    files=$(git grep -l "quay\.io/stackrox-io/apollo-ci:" -- . ':!tools/bump-apollo-ci/' || true)
+
+    while IFS= read -r file; do
</code_context>

<issue_to_address>
**issue (bug_risk):** The exclusion pattern may not work as intended with git grep.

The ':!tools/bump-apollo-ci/' exclusion may not be reliable across git versions. Use 'find' or post-process the results in bash for consistent exclusion.
</issue_to_address>

### Comment 2
<location> `tools/bump-apollo-ci/bump.sh:136-139` </location>
<code_context>
+
+    git push -u origin "$current_branch"
+
+    local existing_pr
+    existing_pr=$(gh pr list --head "$current_branch" --json number,url --jq '.[0] | "\(.number)|\(.url)"' 2>/dev/null || true)
+
+    if [[ -n "$existing_pr" ]] && [[ "$existing_pr" != "null|null" ]] && [[ "$existing_pr" != "|" ]]; then
+        local pr_number="${existing_pr%%|*}"
+        local pr_url="${existing_pr#*|}"
</code_context>

<issue_to_address>
**suggestion:** Parsing PR info with string splitting is fragile.

Using '|' as a delimiter is unreliable if the PR title or URL contains this character. Switching to JSON parsing will ensure accurate extraction of PR details.
</issue_to_address>

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Comment on lines +136 to +139
local existing_pr
existing_pr=$(gh pr list --head "$current_branch" --json number,url --jq '.[0] | "\(.number)|\(.url)"' 2>/dev/null || true)

if [[ -n "$existing_pr" ]] && [[ "$existing_pr" != "null|null" ]] && [[ "$existing_pr" != "|" ]]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Parsing PR info with string splitting is fragile.

Using '|' as a delimiter is unreliable if the PR title or URL contains this character. Switching to JSON parsing will ensure accurate extraction of PR details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants