Address PR review feedback

- Revert TileID to required (present in all products)
- Remove NotGeoreferencedWarning suppression
- Use pytest tmp_path fixture in test
- Clean up test comments

Author: Karthick

src/stactools/modis/metadata.py

@@ -1,6 +1,5 @@
 import datetime
 import os.path
-import warnings
 from dataclasses import dataclass
 from typing import Any, Callable, Dict, List, Optional, Tuple
 
@@ -10,7 +9,6 @@
 from lxml import etree
 from rasterio import Affine
 from rasterio.crs import CRS
-from rasterio.errors import NotGeoreferencedWarning
 from shapely.geometry import shape
 from stactools.core.io import ReadHrefModifier
 from stactools.core.io.xml import XmlElement
@@ -251,7 +249,7 @@ def from_cog_tags(cls, cog_tags: Dict[str, str]) -> "Metadata":
             qa_percent_cloud_cover=None,
             horizontal_tile=horizontal_tile,
             vertical_tile=vertical_tile,
-            tile_id=cog_tags.get("TileID", ""),
+            tile_id=cog_tags["TileID"],
             platforms=sorted(list(platforms)),
             instruments=sorted(list(instruments)),
             collection=collection,
@@ -276,10 +274,8 @@ def from_hdf_href(
         else:
             read_href = href
 
-        with warnings.catch_warnings():
-            warnings.simplefilter("ignore", category=NotGeoreferencedWarning)
-            with rasterio.open(read_href) as dataset:
-                hdf_tags = dataset.tags()
+        with rasterio.open(read_href) as dataset:
+            hdf_tags = dataset.tags()
 
         return cls.from_cog_tags(hdf_tags)
 

tests/test_stac.py

@@ -207,33 +207,23 @@ def test_raster_footprint_geometry() -> None:
         item.validate()
 
 
-def test_create_item_from_hdf_without_xml() -> None:
-    """Test that an item can be created from an HDF file when XML is not available.
-
-    This tests the fallback to extracting metadata directly from the HDF file
-    when the accompanying XML metadata file is not present.
-    """
+def test_create_item_from_hdf_without_xml(tmp_path: Path) -> None:
     hdf_file = "MOD10A2.A2022033.h09v05.061.2022042050729.hdf"
     source_hdf_path = test_data.get_path(f"data-files/{hdf_file}")
 
-    with TemporaryDirectory() as temporary_directory:
-        # Copy only the HDF file (not the XML) to ensure XML is not available
-        temp_hdf_path = os.path.join(temporary_directory, hdf_file)
-        shutil.copyfile(source_hdf_path, temp_hdf_path)
-
-        # Verify XML does not exist in temp directory
-        temp_xml_path = f"{temp_hdf_path}.xml"
-        assert not os.path.exists(temp_xml_path), "XML file should not exist"
-
-        # Create item from HDF only - should extract metadata from HDF
-        item = stactools.modis.stac.create_item(temp_hdf_path)
-
-        # Verify item was created with correct metadata
-        assert item is not None
-        assert item.id.startswith("MOD10A2.A2022033.h09v05")
-        assert "hdf" in item.assets
-        assert "metadata" not in item.assets  # XML asset should not be present
-        item.validate()
+    temp_hdf_path = tmp_path / hdf_file
+    shutil.copyfile(source_hdf_path, temp_hdf_path)
+
+    temp_xml_path = tmp_path / f"{hdf_file}.xml"
+    assert not temp_xml_path.exists()
+
+    item = stactools.modis.stac.create_item(str(temp_hdf_path))
+
+    assert item is not None
+    assert item.id.startswith("MOD10A2.A2022033.h09v05")
+    assert "hdf" in item.assets
+    assert "metadata" not in item.assets
+    item.validate()
 
 
 @pytest.mark.parametrize("file_name", PROJECTION_EDGE_FILES)