1.21.5: Could not pass event PlayerInteractEvent to Stargate v0.11.5.10

[mrpew]

Bug Description

The sign-based menu seems broken in 1.21.5. Portal selection works, however the sign content is not updated so the selection is "blind".

Reproduction Steps

1. Create two gates on the same network
2. Click on either gates sign. Instead of showing the selection list, the sign stays in the "default" state.
3. Exception is thrown on the server (stacktrace below)

Desired Behaviour

Sign content is updated to reflect the current selection.

Observed Behaviour

Sign content stays in the "default state":

Trace Logs

(sg trace does not seem to exist in the legacy release)

[10:21:25 ERROR]: Could not pass event PlayerInteractEvent to Stargate v0.11.5.10
java.lang.NullPointerException: Cannot invoke "String.length()" because "input" is null
        at net.kyori.adventure.text.serializer.legacy.LegacyComponentSerializerImpl.deserialize(LegacyComponentSerializerImpl.java:207) ~[adventure-text-serializer-legacy-4.21.0.jar:?]
        at org.bukkit.craftbukkit.block.sign.CraftSignSide.setLine(CraftSignSide.java:65) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at org.bukkit.craftbukkit.block.CraftSign.setLine(CraftSign.java:68) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at Stargate-0.11.5.10.jar/net.knarcraft.stargate.utility.SignHelper.setSignLine(SignHelper.java:67) ~[Stargate-0.11.5.10.jar:?]
        at Stargate-0.11.5.10.jar/net.knarcraft.stargate.portal.PortalSignDrawer.updateSign(PortalSignDrawer.java:197) ~[Stargate-0.11.5.10.jar:?]
        at Stargate-0.11.5.10.jar/net.knarcraft.stargate.portal.PortalSignDrawer.drawSign(PortalSignDrawer.java:175) ~[Stargate-0.11.5.10.jar:?]
        at Stargate-0.11.5.10.jar/net.knarcraft.stargate.portal.PortalSignDrawer.drawSign(PortalSignDrawer.java:122) ~[Stargate-0.11.5.10.jar:?]
        at Stargate-0.11.5.10.jar/net.knarcraft.stargate.portal.Portal.drawSign(Portal.java:124) ~[Stargate-0.11.5.10.jar:?]
        at Stargate-0.11.5.10.jar/net.knarcraft.stargate.portal.PortalActivator.cycleDestination(PortalActivator.java:275) ~[Stargate-0.11.5.10.jar:?]
        at Stargate-0.11.5.10.jar/net.knarcraft.stargate.portal.PortalActivator.cycleDestination(PortalActivator.java:229) ~[Stargate-0.11.5.10.jar:?]
        at Stargate-0.11.5.10.jar/net.knarcraft.stargate.listener.PlayerEventListener.handleSignClick(PlayerEventListener.java:358) ~[Stargate-0.11.5.10.jar:?]
        at Stargate-0.11.5.10.jar/net.knarcraft.stargate.listener.PlayerEventListener.handleRightClickBlock(PlayerEventListener.java:426) ~[Stargate-0.11.5.10.jar:?]
        at Stargate-0.11.5.10.jar/net.knarcraft.stargate.listener.PlayerEventListener.onPlayerInteract(PlayerEventListener.java:309) ~[Stargate-0.11.5.10.jar:?]
        at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[purpur-api-1.21.5-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:71) ~[purpur-api-1.21.5-R0.1-SNAPSHOT.jar:?]
        at io.papermc.paper.plugin.manager.PaperEventManager.callEvent(PaperEventManager.java:54) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at io.papermc.paper.plugin.manager.PaperPluginManagerImpl.callEvent(PaperPluginManagerImpl.java:131) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:628) ~[purpur-api-1.21.5-R0.1-SNAPSHOT.jar:?]
        at org.bukkit.craftbukkit.event.CraftEventFactory.callPlayerInteractEvent(CraftEventFactory.java:515) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at net.minecraft.server.level.ServerPlayerGameMode.useItemOn(ServerPlayerGameMode.java:480) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at net.minecraft.server.network.ServerGamePacketListenerImpl.handleUseItemOn(ServerGamePacketListenerImpl.java:2081) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at net.minecraft.network.protocol.game.ServerboundUseItemOnPacket.handle(ServerboundUseItemOnPacket.java:45) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at net.minecraft.network.protocol.game.ServerboundUseItemOnPacket.handle(ServerboundUseItemOnPacket.java:10) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at net.minecraft.network.protocol.PacketUtils.lambda$ensureRunningOnSameThread$0(PacketUtils.java:29) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at net.minecraft.server.TickTask.run(TickTask.java:18) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:155) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:24) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:1482) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at net.minecraft.server.MinecraftServer.doRunTask(MinecraftServer.java:175) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:129) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at net.minecraft.server.MinecraftServer.pollTaskInternal(MinecraftServer.java:1462) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at net.minecraft.server.MinecraftServer.pollTask(MinecraftServer.java:1456) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at net.minecraft.util.thread.BlockableEventLoop.managedBlock(BlockableEventLoop.java:139) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at net.minecraft.server.MinecraftServer.managedBlock(MinecraftServer.java:1413) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at net.minecraft.server.MinecraftServer.waitUntilNextTick(MinecraftServer.java:1421) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1298) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at net.minecraft.server.MinecraftServer.lambda$spin$2(MinecraftServer.java:311) ~[purpur-1.21.5.jar:1.21.5-2430-603c755]
        at java.base/java.lang.Thread.run(Unknown Source) ~[?:?]

Other Information

ex. Screenshots, error messages, additional context, bugged files, etc.

[EpicKnarvik97]

I am not sure exactly what the problem is yet, but it seems to be purpur specific. The behavior is as intended on the latest Paper 1.21.5 dev build.

[EpicKnarvik97]

Stargate-0.11.5.10.zip

This build should work on the latest purpur from my testing.

[barstowman]

Even with Stargate-0.11.5.10.zip the error occurs in versions 1.21.7 and 1.21.8. When no destination is specified on line 2, the error above still occurs.
Gates that have already been created in recent Minecraft versions still work. It is just new gates that don't work. Intermittently, you can get a new gate to work once, but then it fails again.

[EpicKnarvik97]

I haven't really gotten any feeback elsewhere if my changes worked, but as I am personally unable to trigger the issue no matter what, I tried removing the legacy sign drawing from the code, as it's the only potential culprit I could see. Please tell me if it makes any difference at all.

Stargate-0.11.5.11.zip

Edit: I was told this fixed the problem for others.

[EpicKnarvik97]

People (in the Discord) have confirmed that Stargate 0.11.5.11 fixes the issue.