-
Notifications
You must be signed in to change notification settings - Fork 758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reimplement json-bigint #52
Labels
Comments
janek26
added
Type: feature
New feature or request
good first issue
Good for newcomers
labels
Nov 9, 2021
FYI I'm hitting this issue with json-bigint when using starknet.js . |
wraitii
added a commit
to briqNFT/briq-builder
that referenced
this issue
Nov 16, 2021
See starknet-io/starknet.js#52 for the custom json-bigint import
on hold. |
janek26
removed
Type: feature
New feature or request
good first issue
Good for newcomers
labels
Jan 19, 2022
Closed with #560, if something is missing please reopen :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
One of our dependencies https://github.com/sidorares/json-bigint has seen it's best days.
It uses bignumber.js as a dependency, while this library uses bn.js. It also supports native BigInt which breaks support for older browsers and browserslists (see #37 ).
Lets reimplement this package in TS.
As a starting point we can use the test suites provided at the original repo and write an implementation against it.
We can ether make this repo a monorepo or start a new repo.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: