Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reimplement json-bigint #52

Closed
janek26 opened this issue Nov 9, 2021 · 3 comments
Closed

Reimplement json-bigint #52

janek26 opened this issue Nov 9, 2021 · 3 comments
Labels
waiting on StarkWare wontfix This will not be worked on

Comments

@janek26
Copy link
Member

janek26 commented Nov 9, 2021

One of our dependencies https://github.com/sidorares/json-bigint has seen it's best days.
It uses bignumber.js as a dependency, while this library uses bn.js. It also supports native BigInt which breaks support for older browsers and browserslists (see #37 ).

Lets reimplement this package in TS.
As a starting point we can use the test suites provided at the original repo and write an implementation against it.

We can ether make this repo a monorepo or start a new repo.

Acceptance Criteria

  • no use of native BigInt
  • use BN.js as only dependency
  • passes all test from the original repo
@janek26 janek26 added Type: feature New feature or request good first issue Good for newcomers labels Nov 9, 2021
@wraitii
Copy link

wraitii commented Nov 15, 2021

FYI I'm hitting this issue with json-bigint when using starknet.js .
My temp fix is to pull from git+https://github.com/bushev/json-bigint.git#e3e93f71d633cd558bc7c57afcd9e1f54f669d0b in my package.json

wraitii added a commit to briqNFT/briq-builder that referenced this issue Nov 16, 2021
@janek26
Copy link
Member Author

janek26 commented Dec 9, 2021

on hold.
Maybe Starkware moves to using hex everywhere in compiled contracts which would solve this and remove the bitint json dependency

@ivpavici
Copy link
Collaborator

ivpavici commented Mar 30, 2023

Closed with #560, if something is missing please reopen :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting on StarkWare wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

4 participants