[Depends on #239] Fix indigo & kinetic build #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
昨日までアクセスできていた |
Member
このやり方で問題ないと思います。 |
io/iob.h -> hrpsys/io/iob.h See fkanehiro/hrpsys-base#842
This reverts commit 03b3266.
io/iob.h -> hrpsys/io/iob.h See fkanehiro/hrpsys-base#842
pazeshun
force-pushed
the
fix-indigo-kinetic-build
branch
from
ab56c3e to
11de69e
Compare
Collaborator
Author
Open Roboticsにメールで聞いたところ、以下のURLに移動したようです。 |
Collaborator
Author
|
#241 で失敗するtravisがこのPRで成功するのを確認しました。 |
Collaborator
Author
|
@ban-masa のindigo環境で、ビルドができ、HRP2が歩くことを確認しました。 |
Contributor
|
kineticのユースケースに対応できていることを確認しました。 ビルドができ、HRP2が歩くことを確認しました。 |
k-okada
added a commit
that referenced
this pull request
Dec 11, 2019
…trollers [on #242] add options to gazebo_robot_no_controllers.launch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version of #240
Includes #241 and #237
#241 で失敗するtravisが、このPRでの修正により成功するようになります。
@YoheiKakiuchi #219 と同じ問題がhrpsys_gazebo_atlasで起きたのですが、修正方法を #221 ではなく、fkanehiro/hrpsys-base#842 と同様 (io/iob.h -> hrpsys/io/iob.h) とし、hrpsys_gazebo_generalにおいても #220 をrevertして同様の変更を行いました。これで大丈夫でしょうか。
@iory @Naoki-Hiraoka #237 をindigoでもビルドできるように修正しました。これでindigo, kineticのユースケースに対応できているか、ご確認ください。