refactor(SwapModal): Remove Global Swap Launch Signal in Favor of Scoped Handler

Eliminated the use of the `Global` signal to initiate `Swap`. Replaced it with a context-specific handler to improve modularity and reduce global coupling.

Author: noeliaSD

ui/app/AppLayouts/Wallet/WalletLayout.qml

@@ -57,6 +57,8 @@ Item {
     signal sendTokenRequested(string senderAddress, string tokenId, int tokenType)
     signal bridgeTokenRequested(string tokenId, int tokenType)
 
+    signal openSwapModalRequested(var swapFormData)
+
     onAppMainVisibleChanged: {
         resetView()
     }
@@ -258,11 +260,7 @@ Item {
                 d.swapFormData.selectedAccountAddress = d.getSelectedOrFirstNonWatchedAddress()
                 d.swapFormData.selectedNetworkChainId = StatusQUtils.ModelUtils.getByKey(root.networksStore.activeNetworks, "layer", 1, "chainId")
                 d.swapFormData.fromTokensKey = tokensKey
-                Global.openSwapModalRequested(d.swapFormData, (popup) => {
-                    popup.Component.destruction.connect(() => {
-                        d.swapFormData.resetFormData()
-                    })
-                })
+                root.openSwapModalRequested(d.swapFormData)
             }
             onDappListRequested: root.dappListRequested()
             onDappConnectRequested: root.dappConnectRequested()
@@ -391,11 +389,7 @@ Item {
                 if(!!walletStore.currentViewedHoldingTokensKey && walletStore.currentViewedHoldingType === Constants.TokenType.ERC20) {
                     d.swapFormData.fromTokensKey =  walletStore.currentViewedHoldingTokensKey
                 }
-                Global.openSwapModalRequested(d.swapFormData, (popup) => {
-                    popup.Component.destruction.connect(() => {
-                        d.swapFormData.resetFormData()
-                    })
-                })
+                root.openSwapModalRequested(d.swapFormData)
             }
             onLaunchBuyCryptoModal: d.launchBuyCryptoModal()
 

ui/app/mainui/AppMain.qml

@@ -1986,6 +1986,7 @@ Item {
                             onBridgeTokenRequested: (tokenId, tokenType) => {
                                                         popupRequestsHandler.sendModalHandler.bridgeToken(tokenId, tokenType)
                                                     }
+                            onOpenSwapModalRequested: popupRequestsHandler.swapModalHandler.launchSwapSpecific(swapFormData)
                         }
                         onLoaded: {
                             item.resetView()

ui/app/mainui/Handlers/HandlersManager.qml

@@ -45,10 +45,17 @@ QtObject {
                     SQUtils.ModelUtils.get(root.walletRootStore.nonWatchAccounts, 0, "address")
             swapFormData.selectedNetworkChainId =
                     SQUtils.ModelUtils.getByKey(root.networksStore.activeNetworks, "layer", 1, "chainId")
-            Global.openSwapModalRequested(swapFormData, (popup) => {
-                                              popup.Component.destruction.connect(() => {
-                                                                                      swapFormData.resetFormData()
-                                                                                  })})
+            openSendModal(swapFormData, (popup) => {
+                              popup.Component.destruction.connect(() => {
+                                                                      swapFormData.resetFormData()
+                                                                  })})
+        }
+
+        function launchSwapSpecific(data) {
+            openSendModal(data, (popup) => {
+                              popup.Component.destruction.connect(() => {
+                                                                      data.resetFormData()
+                                                                  })})
         }
 
         popupParent: root.popupParent

ui/app/mainui/Handlers/SwapModalHandler.qml

@@ -18,11 +18,6 @@ QtObject {
     required property WalletStores.WalletAssetsStore walletAssetsStore
     required property NetworksStore networksStore
 
-    Component.onCompleted: {
-        // TODO update opening logic to be similar to send
-        Global.openSwapModalRequested.connect(openSendModal)
-    }
-
     function openSendModal(params = {}, callback = null) {
         d.swapInputParams = params
         let swapModalInst = swapModalComponent.createObject(popupParent)

ui/imports/utils/Global.qml

@@ -92,9 +92,6 @@ QtObject {
 
     signal openNewsMessagePopupRequested(var notification, string notificationId)
 
-    // Swap
-    signal openSwapModalRequested(var formDataParams, var callback)
-
     // BuyCrypto
     signal openBuyCryptoModalRequested(var formDataParams)