Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update logic for splitting sentences #3089

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: update logic for splitting sentences #3089

wants to merge 1 commit into from

Conversation

MVARUNREDDY8203
Copy link

Resolves #3017

Description

What is the purpose of this pull request?

This pull request:

this pull request :

  • resolves the issue with splitting sentences where the previous version wrongly splits sentences on punctuation marks before closing " or '

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

stdlib-bot
stdlib-bot reviewed Nov 10, 2024
View reviewed changes
Copy link
Contributor

@stdlib-bot stdlib-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi there! 👋

And thank you for opening your first pull request! We will review it shortly. 🏃 💨

@MVARUNREDDY8203
Copy link
Author

MVARUNREDDY8203 commented Nov 10, 2024 •
edited
Loading

this pr solves the issue #3017

I have added logic to ensure that punctuation marks like ! or ? followed by closing " or ' don't split the sentences there after.
I have run all tests and all tests have passed.

kgryte
kgryte reviewed Nov 13, 2024
View reviewed changes
.github/workflows/scripts/generate_pr_commit_message
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MVARUNREDDY8203 Can you explain why this PR is changing this file?

@kgryte kgryte added the Do Not Merge Pull request which should not be merged. label Nov 13, 2024
@kgryte kgryte changed the title fix: resolve issue #3017 with sentence splitting fix: update logic for splitting sentences Nov 13, 2024
@kgryte kgryte added the Needs Discussion Needs further discussion. label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdlib-bot stdlib-bot stdlib-bot left review comments

@kgryte kgryte kgryte left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Do Not Merge Pull request which should not be merged. Needs Discussion Needs further discussion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: nlp-sentencize wrongly breaks sentences in quotation marks
4 participants
@MVARUNREDDY8203 @kgryte @stdlib-bot @Planeshifter