feat: add math/base/special/sqrtpif
#3116
Open
+2,294
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gunjjoshi, The test cases are failing for this package. Can you review |
gunjjoshi
reviewed
Nov 15, 2024
|
|
||
| var sqrtf = require( '@stdlib/math/base/special/sqrtf' ); | ||
| var PI = require( '@stdlib/constants/float32/pi' ); | ||
|
|
There was a problem hiding this comment.
Suggested change
| var float64ToFloat32 = require( '@stdlib/number/float64/base/to-float32' ); | |
| * // returns NaN | ||
| */ | ||
| function sqrtpif( x ) { | ||
| return sqrtf( x * PI ); |
There was a problem hiding this comment.
Suggested change
| return sqrtf( x * PI ); | |
| return sqrtf( float64ToFloat32( float64ToFloat32( x ) * PI ) ); |
There was a problem hiding this comment.
You should use float64ToFloat32 to wrap the input values and arithmetic operations, when dealing with single-precision calculations.
There was a problem hiding this comment.
This is similar to what we follow in math/base/special/sqrtf: https://github.com/stdlib-js/stdlib/blob/develop/lib/node_modules/%40stdlib/math/base/special/sqrtf/lib/main.js
kgryte
added
Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves a part of #649 .
Description
Adds package
math/base/special/sqrtpifThis pull request:
Related Issues
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers