feat: add math/base/special/sqrtpif#3116
Conversation
|
@gunjjoshi, The test cases are failing for this package. Can you review |
lib/node_modules/@stdlib/math/base/special/sqrtpif/test/fixtures/julia/runner.jl
Outdated
Show resolved
Hide resolved
Coverage Report
The above coverage report was generated for the changes in this PR. |
|
/stdlib merge |
|
/stdlib merge |
|
@gunjjoshi, PR is ready for a review. |
Signed-off-by: Gunj Joshi <[email protected]>
Signed-off-by: Gunj Joshi <[email protected]>
|
@gururaj1512 Can you please modify the JS and C benchmarks to pre-compute the values, outside the loop? This applies to the JS examples as well. |
|
Also, @gururaj1512, you'll need to add the |
@gunjjoshi, Updated the code as suggested. Ready for review |
lib/node_modules/@stdlib/math/base/special/sqrtpif/benchmark/benchmark.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/sqrtpif/benchmark/benchmark.native.js
Outdated
Show resolved
Hide resolved
lib/node_modules/@stdlib/math/base/special/sqrtpif/examples/index.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Philipp Burckhardt <[email protected]>
Planeshifter
left a comment
There was a problem hiding this comment.
Thank you @gururaj1512!
Did another review pass after @gunjjoshi's and this PR should be ready to land now.
Resolves a part of #649 .
Description
Adds package
math/base/special/sqrtpifThis pull request:
Related Issues
Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers